Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22604 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 61339 invoked by uid 1010); 28 Mar 2006 00:23:47 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 61324 invoked from network); 28 Mar 2006 00:23:47 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Mar 2006 00:23:47 -0000 X-Host-Fingerprint: 219.166.150.11 mx1.es-i.jp Linux 2.4 w/o timestamps Received: from ([219.166.150.11:47317] helo=mx1.es-i.jp) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 95/F1-37235-21288244 for ; Mon, 27 Mar 2006 19:23:47 -0500 Received: (qmail 3295 invoked by uid 501); 28 Mar 2006 00:23:43 -0000 Received: from yohgaki@ohgaki.net by mx1.es-i.jp by uid 401 with qmail-scanner-1.20 (clamscan: 0.65. spamassassin: 2.60. Clear:RC:1(192.168.100.210):. Processed in 0.014731 secs); 28 Mar 2006 00:23:43 -0000 X-Qmail-Scanner-Mail-From: yohgaki@ohgaki.net via mx1.es-i.jp X-Qmail-Scanner: 1.20 (Clear:RC:1(192.168.100.210):. Processed in 0.014731 secs) Received: from unknown (HELO ?127.0.0.1?) (192.168.100.210) by mx1.es-i.jp with SMTP; 28 Mar 2006 00:23:43 -0000 Message-ID: <44288282.3070009@ohgaki.net> Date: Tue, 28 Mar 2006 09:25:38 +0900 User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: Wez Furlong CC: Lukas Smith , internals@lists.php.net References: <4425040E.60402@ohgaki.net> <44250532.7070509@php.net> <44275330.7050508@ohgaki.net> <44279BCB.1090105@php.net> <44280F96.3090600@ohgaki.net> <44281210.3000103@php.net> <442816CF.6040305@ohgaki.net> <4e89b4260603271311m50dcbdbbw8b29b0ddf712baf6@mail.gmail.com> In-Reply-To: <4e89b4260603271311m50dcbdbbw8b29b0ddf712baf6@mail.gmail.com> X-Enigmail-Version: 0.94.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: pg_execute error From: yohgaki@ohgaki.net (Yasuo Ohgaki) Wez Furlong wrote: > Regardless of whether it's a good idea or not, you should not just go > ahead and commit such a big behaviour change to the stable branch > during the release process. > > Please revert your commit. That's good point. Any people should not depend on pg_execute's E_WARNING error in transaction, but I'll revert patch against PHP_5_1. -- Yasuo Ohgaki > > --Wez. > > On 3/27/06, Yasuo Ohgaki wrote: >> Lukas Smith wrote: >>> So why dont you just do @pg_execute() and in your error handler you can do: >>> >>> function ErrorHandler($errno, $errstr, $errfile, $errline) >>> { >>> // ignore silenced function calls >>> if (!error_reporting()) { >>> return; >>> } >>> .. >>> >>> If you want a "beautiful" solution you will have to manage your prepared >>> statements in some persistant layer. >> This is one option. >> >> @ operator is ok, but usually @ operator is not recommenned. >> Don't you think so? I try not to use @ as much as possible. >> >> pg_execute() does not have to raise error just like file_exists(). >> It may be good idea to raise error when connection is bad, etc. >> >> -- >> Yasuo Ohgaki >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > >