Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22541 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27215 invoked by uid 1010); 20 Mar 2006 15:46:35 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 27199 invoked from network); 20 Mar 2006 15:46:35 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Mar 2006 15:46:35 -0000 X-Host-Fingerprint: 204.11.219.139 lerdorf.com Linux 2.4/2.6 Received: from ([204.11.219.139:40111] helo=colo.lerdorf.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 1E/60-55982-A5ECE144 for ; Mon, 20 Mar 2006 10:46:35 -0500 Received: from [192.168.200.106] (c-24-6-5-134.hsd1.ca.comcast.net [24.6.5.134]) (authenticated bits=0) by colo.lerdorf.com (8.13.5/8.13.5/Debian-3) with ESMTP id k2KFkUxi026848; Mon, 20 Mar 2006 07:46:31 -0800 Message-ID: <441ECE55.2040803@lerdorf.com> Date: Mon, 20 Mar 2006 07:46:29 -0800 User-Agent: Thunderbird 3.0a1 (Macintosh/20060318) MIME-Version: 1.0 To: Zeev Suraski CC: internals References: <44183C6F.900@lerdorf.com> <7.0.1.0.2.20060320144418.0ad572d0@zend.com> <441EB719.6050104@lerdorf.com> <7.0.1.0.2.20060320170743.0addfec0@zend.com> In-Reply-To: <7.0.1.0.2.20060320170743.0addfec0@zend.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] auto_globals_jit and register_argc_argv disconnect From: rasmus@lerdorf.com (Rasmus Lerdorf) Zeev Suraski wrote: > At 16:07 20/03/2006, Rasmus Lerdorf wrote: >> Zeev Suraski wrote: >>> At 18:10 15/03/2006, Rasmus Lerdorf wrote: >>>> Our default config has both auto_globals_jit and register_argc_argv >>>> enabled. However, having register_argc_argv enabled disables >>>> auto_globals_jit which carries a really high WTF factor. >>> I don't think WTF terminology fits here, as it's an extreme case of >>> performance optimization and doesn't affect functionality. Not >>> exactly the interest of the average (and even advanced) user. It's >>> end-user (developer) transparent. Irregardless, I actually think it >>> makes perfect sense that if you ask PHP to do stuff with GET / POST >>> variables on every request (register_argc_argv), it wouldn't make >>> sense to JIT them. >> >> We don't jit GET/POST. > > OK, I agree with you, the correlation is a weaker than I thought (didn't > recall I didn't get around to JIT'ing get/post). If we were to do it it > probably makes sense to just keep a global reference to argv/argc, and > move the code that puts them into _SERVER to > php_register_server_variables(). Should be pretty clean, no? Pretty much what we did already. You are running about a week behind. ;) -Rasmus