Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:22539
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <7.0.1.0.2.20060320170743.0addfec0@zend.com>
Date: Mon, 20 Mar 2006 17:19:36 +0200
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: internals <internals@lists.php.net>
In-Reply-To: <441EB719.6050104@lerdorf.com>
References: <44183C6F.900@lerdorf.com>
	<7.0.1.0.2.20060320144418.0ad572d0@zend.com>
	<441EB719.6050104@lerdorf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] auto_globals_jit and register_argc_argv 
	disconnect
From: zeev@zend.com (Zeev Suraski)

At 16:07 20/03/2006, Rasmus Lerdorf wrote:
>Zeev Suraski wrote:
>>At 18:10 15/03/2006, Rasmus Lerdorf wrote:
>>>Our default config has both auto_globals_jit and 
>>>register_argc_argv enabled.  However, having register_argc_argv 
>>>enabled disables auto_globals_jit which carries a really high WTF factor.
>>I don't think WTF terminology fits here, as it's an extreme case of 
>>performance optimization and doesn't affect functionality.  Not 
>>exactly the interest of the average (and even advanced) user.  It's 
>>end-user (developer) transparent.  Irregardless, I actually think 
>>it makes perfect sense that if you ask PHP to do stuff with GET / 
>>POST variables on every request (register_argc_argv), it wouldn't 
>>make sense to JIT them.
>
>We don't jit GET/POST.

OK, I agree with you, the correlation is a weaker than I thought 
(didn't recall I didn't get around to JIT'ing get/post).  If we were 
to do it it probably makes sense to just keep a global reference to 
argv/argc, and move the code that puts them into _SERVER to 
php_register_server_variables().  Should be pretty clean, no?

Zeev