Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22523 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10727 invoked by uid 1010); 18 Mar 2006 23:34:19 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 10712 invoked from network); 18 Mar 2006 23:34:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Mar 2006 23:34:19 -0000 X-Host-Fingerprint: 66.249.92.207 uproxy.gmail.com Linux 2.4/2.6 Received: from ([66.249.92.207:50631] helo=uproxy.gmail.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 04/5C-55982-BF89C144 for ; Sat, 18 Mar 2006 18:34:19 -0500 Received: by uproxy.gmail.com with SMTP id m3so463553uge for ; Sat, 18 Mar 2006 15:34:16 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=W098B7jKB+gOb25PN+5AIW9OgNsjpoF+W+fPSIjbT3G+WHxCGXHffc/PsUCVlZfrPydIOuyw+yibYCMbRqK6GYjbFo2KKpxHCepKAxXsJAph86O9srYPvM+xlsIfk5HiEHp52aqTShlzh988U/9sVClx+a6AdnW/hKRbhvLBFHA= Received: by 10.66.243.6 with SMTP id q6mr2715601ugh; Sat, 18 Mar 2006 15:34:16 -0800 (PST) Received: by 10.67.26.18 with HTTP; Sat, 18 Mar 2006 15:34:16 -0800 (PST) Message-ID: Date: Sun, 19 Mar 2006 00:34:16 +0100 To: "Wez Furlong" Cc: internals@lists.php.net In-Reply-To: <4e89b4260603181526q4a36d446tb1d5b6cb876b1640@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060318224305.1681de1f@localhost.localdomain> <4e89b4260603181526q4a36d446tb1d5b6cb876b1640@mail.gmail.com> Subject: Re: [PHP-DEV] PDO, dbh::setDefaultFetchMode patch From: pierre.php@gmail.com (Pierre) On 3/19/06, Wez Furlong wrote: > It breaks the ABI; always add new structure members at the end of > structures, and always bump the API number when you change anything > like that in the pdo driver header file. Ok, not a problem to move it at the end. > Aside from that, although I personally wouldn't use this patch, it looks = OK. It is for lazy coders like me ;-) Ilia is fine to add it to 5.x (after 5.1.3), I will commit once 5.1.3 is released, head and to the active 5.x branche. Thanks for the feedback :) --Pierre