Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22514 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 93546 invoked by uid 1010); 17 Mar 2006 23:31:09 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 93531 invoked from network); 17 Mar 2006 23:31:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 17 Mar 2006 23:31:08 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:42530] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id AD/26-55982-BB64B144 for ; Fri, 17 Mar 2006 18:31:07 -0500 Received: from baumbart.mbo (dslb-084-063-018-253.pools.arcor-ip.net [84.63.18.253]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id ED73535C1C8; Sat, 18 Mar 2006 00:31:02 +0100 (CET) Date: Sat, 18 Mar 2006 00:33:07 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <123559964.20060318003307@marcus-boerger.de> To: Michael Wallner Cc: internals@lists.php.net In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Please review: new output control implementation From: helly@php.net (Marcus Boerger) Hello Michael, Friday, March 17, 2006, 4:09:12 PM, you wrote: > I wrote: >> References: >> [0] http://dev.iworks.at/PATCHES/output/ >> [1] http://dev.iworks.at/PATCHES/output/ob.patch.txt.gz >> [2] http://dev.iworks.at/PATCHES/output/php_output.h.txt >> [3] http://dev.iworks.at/PATCHES/output/output.c.txt >> [4] http://dev.iworks.at/PATCHES/output/README.NEW-OUTPUT-API > Should I interpret the sustained silence as no interest in it? I'd say the only thing that doesn't look ten times better than what we have right now is that you have exported function prefixed with underscore "PHPAPI int _php_output" and static ones without. Imo it should be the other way round. The open question i have however is how do you deal with unicode. I saw some estr*() calls where i would have expected a few unicode checks. So there is no unicode support right now. So i suggest you add that too. A think i am a bit curious yout is why some function have both *() and *_all() versions. Why didn't you choose to pass an int in? Last but not least i wonder why i am seeing use of the strange TSRMLS_FETCH_FROM_CTX() instead of passing TSRM keys using TSRMLS_* macros. Best regards, Marcus