Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22314 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95864 invoked by uid 1010); 9 Mar 2006 23:44:42 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 95849 invoked from network); 9 Mar 2006 23:44:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Mar 2006 23:44:42 -0000 X-Host-Fingerprint: 213.237.67.135 213.237.67.135.adsl.by.worldonline.dk Linux 2.4/2.6 Received: from ([213.237.67.135:25294] helo=mail.ter.dk) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 8F/8D-27106-AEDB0144 for ; Thu, 09 Mar 2006 18:44:42 -0500 Received: from workpenguin (workpenguin [192.168.1.32]) by mail.ter.dk (Kaffemaskine) with SMTP id 7DB968A40E8; Fri, 10 Mar 2006 00:44:29 +0100 (CET) To: andi@zend.com (Andi Gutmans) Cc: internals@lists.php.net Date: Fri, 10 Mar 2006 00:42:48 +0100 Message-ID: <7dd112p5kh1gj0lt13dlh6uita42llsir4@4ax.com> References: <7.0.1.0.2.20060218170026.02a224f8@zend.com> In-Reply-To: <7.0.1.0.2.20060218170026.02a224f8@zend.com> X-Mailer: Forte Agent 1.91/32.564 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: Re: Nuking safe_mode From: penguin@php.net (Peter Brodersen) Hi, Just got home from a month in South America and is trying to catch up on old posts... On Sat, 18 Feb 2006 17:02:32 -0800, in php.internals andi@zend.com (Andi Gutmans) wrote: >I'm nuking safe_mode and I found something odd. In streams,=20 >php_plain_files_unlink() only checks php_check_open_basedir() when=20 >ENFORCE_SAFE_MODE is flagged. I was planning on nuking=20 >ENFORCE_SAFE_MODE completely. Is this a bug? Or should I rename=20 >ENFORCE_SAFE_MODE to ENFORCE_OPEN_BASEDIR? Rasmus mentions in <43874C56.8050007@lerdorf.com> / http://news.php.net/php.internals/20417 that it might be a good idea unwrapping the safe_mode_exec_dir check from the uid matching. The trouble about "safe mode" seems mainly to be the expression (based on the notes in http://www.php.net/~derick/meeting-notes.html#safe-mode ) and the spurious UID checks. In the same old thread it didn't seem like there was a consensus or best practice regarding the exec functions. Some recommended using disabled_functions, but this would just be asking people to "remake" and maintain their own list of functions that safe_mode (under any other name) would have disabled for them. Would the feature of safe_mode_exec_dir in any kind of name be preserved, as recommended by Rasmus? This might be the exact time to "remind us later". --=20 - Peter Brodersen