Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22239 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 14019 invoked by uid 1010); 8 Mar 2006 00:47:17 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 14003 invoked from network); 8 Mar 2006 00:47:17 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Mar 2006 00:47:17 -0000 X-Host-Fingerprint: 217.79.190.163 r163.red.fastwebserver.de Received: from ([217.79.190.163:5847] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 21/FB-27106-4992E044 for ; Tue, 07 Mar 2006 19:47:16 -0500 To: internals@lists.php.net,pierre.php@gmail.com (Pierre) Date: Wed, 8 Mar 2006 01:47:11 +0100 Message-ID: <20060308014711.19dcaff8@localhost.localdomain> In-Reply-To: References: <20060307042941.1c7d06c1@localhost.localdomain> <20060307151627.67579a91@localhost.localdomain> Reply-To: pierre.php@gmail.com X-Newsreader: Sylpheed-Claws 1.9.14 (GTK+ 2.8.6; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Posted-By: 217.79.190.163 Subject: Re: [PHP-DEV] Adieu a la magie (remove magic_quotes) From: pierre.php@gmail.com (Pierre) On Tue, 7 Mar 2006 16:22:08 +0100 pierre.php@gmail.com (Pierre) wrote: > On 3/7/06, Pierre wrote: > > > > On 3/7/06, Zeev Suraski wrote: > > > > > The point is that breakage is aggregated, not binary. The more > > > stuff we break, the more difficult it is to port, and frankly, > > > it's quite likely that a non OO app could migrate fairly cleanly > > > even to PHP 6 with unicode disabled (perhaps with minor > > > fixes). get_magic_quotes_gpc() is designed for apps to do > > > something differently depending on the value of > > > magic_quotes_gpc. It's fine that it's always off in PHP 6, but > > > there's no reason not to keep this function (to always return > > > false) so that you don't have to fix God knows how many lines of > > > code to remove it. > > > > Fair enough, as I said in my last post in the magic_quotes thread, > > it is easy to keep this function. I will modify the patch to keep > > the related functions (returning always false). Is is ok? > > The patch is now updated (same link). The functions are restored but > deprecated using the new ZEND_DEP_* macros. > > set_magic_quotes_runtime raise a E_CORE_ERROR as described in the PDM. > The other always return false. > > No more objection? Done, as Zeev said, the functions are kept and return false, except for set_magic_quotes_runtime which raises a core error. They are declared using the depracated flag. --Pierre