Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22203 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18021 invoked by uid 1010); 7 Mar 2006 15:22:13 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 18006 invoked from network); 7 Mar 2006 15:22:12 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Mar 2006 15:22:12 -0000 X-Host-Fingerprint: 66.249.92.192 uproxy.gmail.com Linux 2.4/2.6 Received: from ([66.249.92.192:56251] helo=uproxy.gmail.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 00/73-22029-425AD044 for ; Tue, 07 Mar 2006 10:22:12 -0500 Received: by uproxy.gmail.com with SMTP id a2so712782ugf for ; Tue, 07 Mar 2006 07:22:08 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=rlaEHudJUVJVUnlg/54Ii4Cs56Uf+gTLfsrpOp0S7guw7K4JnUWMEUhvgTlbH95H36GDsMEtGWrSeoN4kUKzU4FwtZf4fFFdh3J3dZQgC0zmp7Ao1AzeBsJe3FLUc5o/dqKiP1plEKJZiqim/LP9AEwkGc1v0/jrDuhG/FRPT+I= Received: by 10.66.245.7 with SMTP id s7mr3374731ugh; Tue, 07 Mar 2006 07:22:08 -0800 (PST) Received: by 10.67.26.18 with HTTP; Tue, 7 Mar 2006 07:22:08 -0800 (PST) Message-ID: Date: Tue, 7 Mar 2006 16:22:08 +0100 To: internals@lists.php.net, "Zeev Suraski" , "Derick Rethans" In-Reply-To: <20060307151627.67579a91@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20060307042941.1c7d06c1@localhost.localdomain> <20060307151627.67579a91@localhost.localdomain> Subject: Re: [PHP-DEV] Adieu a la magie (remove magic_quotes) From: pierre.php@gmail.com (Pierre) On 3/7/06, Pierre wrote: > > On 3/7/06, Zeev Suraski wrote: > > > The point is that breakage is aggregated, not binary. The more stuff > > we break, the more difficult it is to port, and frankly, it's quite > > likely that a non OO app could migrate fairly cleanly even to PHP 6 > > with unicode disabled (perhaps with minor > > fixes). get_magic_quotes_gpc() is designed for apps to do something > > differently depending on the value of magic_quotes_gpc. It's fine > > that it's always off in PHP 6, but there's no reason not to keep this > > function (to always return false) so that you don't have to fix God > > knows how many lines of code to remove it. > > Fair enough, as I said in my last post in the magic_quotes thread, it > is easy to keep this function. I will modify the patch to keep the > related functions (returning always false). Is is ok? The patch is now updated (same link). The functions are restored but deprecated using the new ZEND_DEP_* macros. set_magic_quotes_runtime raise a E_CORE_ERROR as described in the PDM. The other always return false. No more objection? --Pierre