Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22163 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 73135 invoked by uid 1010); 7 Mar 2006 05:09:27 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 73120 invoked from network); 7 Mar 2006 05:09:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Mar 2006 05:09:27 -0000 X-Host-Fingerprint: 193.252.22.54 smtp13.wanadoo.fr Linux 2.4/2.6 Received: from ([193.252.22.54:38582] helo=smtp13.wanadoo.fr) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 66/C6-22029-5851D044 for ; Tue, 07 Mar 2006 00:09:25 -0500 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf1301.wanadoo.fr (SMTP Server) with ESMTP id BBE967000091 for ; Tue, 7 Mar 2006 06:09:21 +0100 (CET) Received: from binarysecfb111 (AStDenis-102-1-6-21.w81-248.abo.wanadoo.fr [81.248.227.21]) by mwinf1301.wanadoo.fr (SMTP Server) with SMTP id 19AEE700008D; Tue, 7 Mar 2006 06:09:19 +0100 (CET) X-ME-UUID: 20060307050920105.19AEE700008D@mwinf1301.wanadoo.fr Message-ID: <006301c641a5$17625f50$6600a8c0@binarysecfb111> To: Cc: "PHPdev" References: <20060305162128.5b1fdb86@localhost.localdomain> <20060306214619.5e6ec076@localhost.localdomain> Date: Tue, 7 Mar 2006 06:07:51 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2180 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 Subject: Re: [PHP-DEV] Re: Adieu register_globals From: mv-php@binarysec.com ("Michael Vergoz") Finally ! Good job Pierre :D +1 Michael ----- Original Message ----- From: "Pierre" To: ; Sent: Monday, March 06, 2006 9:46 PM Subject: [PHP-DEV] Re: Adieu register_globals > On Sun, 5 Mar 2006 16:21:28 +0100 > pierre.php@gmail.com (Pierre) wrote: > >> Hello, >> >> As discussed last year, register_globals will be removed in php6. This >> patch is the first step: >> >> http://pear.php.net/~pierre/remove_register_globals.txt >> >> The only thing I find confusing is a comment in main/php_variables.c >> php_autoglobal_merge. The comment says something and the tests >> something else (register_globals AND instead of register_globals OR). >> I will review all the affected tests if you consider this patch ok to >> be commited. Some will be updated, other simply removed. >> >> I did not run benchmarks, but I feel like it speeds up php a bit :) >> >> Comments and feedbacks welcome, > > Still welcome... > > The patch includes now: > - the all tests fixes (session) > * tests being useless now are skiped (to allow review, will removed > later) > - functions removed: > * session_register > * session_unregister > * session_is_registered > They need register_globals to work > > I will wait until wednesday for feedbacks or objections, and commit on > thursday. > > --Pierre > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >