Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22151 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54516 invoked by uid 1010); 6 Mar 2006 23:58:58 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 54501 invoked from network); 6 Mar 2006 23:58:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Mar 2006 23:58:58 -0000 X-Host-Fingerprint: 66.216.66.81 mail.ionzoft.com Linux 2.4/2.6 Received: from ([66.216.66.81:39634] helo=mail.ionzoft.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 7D/88-22029-1CCCC044 for ; Mon, 06 Mar 2006 18:58:57 -0500 Received: from JASONGARBER2 (207-255-4-232-static.aoo.pa.atlanticbb.net [207.255.4.232]) by mail.ionzoft.com (Postfix) with ESMTP id 7B4538A400A; Mon, 6 Mar 2006 18:59:59 -0500 (EST) Date: Mon, 6 Mar 2006 18:56:51 -0500 X-Mailer: The Bat! (v3.65.03) Professional Reply-To: Jason Garber Organization: IonZoft, Inc. X-Priority: 3 (Normal) Message-ID: <12610554706.20060306185651@ionzoft.com> To: Zeev Suraski CC: pierre.php@gmail.com, internals@lists.php.net In-Reply-To: <7.0.1.0.2.20060307013655.0c0064a8@zend.com> References: <20060305162128.5b1fdb86@localhost.localdomain> <20060306214619.5e6ec076@localhost.localdomain> <7.0.1.0.2.20060307013655.0c0064a8@zend.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Adieu register_globals From: jason@ionzoft.com (Jason Garber) Hello Zeev, I'd be happy to do this. Do you want this placed in a function or just sample code to post somewhere? -- Best regards, Jason mailto:jason@ionzoft.com Monday, March 6, 2006, 6:38:34 PM, you wrote: ZS> A part of the decision was to supply the few lines of code necessary ZS> to emulate register_globals in userspace. Volunteers? :) ZS> Zeev ZS> At 22:46 06/03/2006, Pierre wrote: >>On Sun, 5 Mar 2006 16:21:28 +0100 >>pierre.php@gmail.com (Pierre) wrote: >> >> > Hello, >> > >> > As discussed last year, register_globals will be removed in php6. This >> > patch is the first step: >> > >> > http://pear.php.net/~pierre/remove_register_globals.txt >> > >> > The only thing I find confusing is a comment in main/php_variables.c >> > php_autoglobal_merge. The comment says something and the tests >> > something else (register_globals AND instead of register_globals OR). >> > I will review all the affected tests if you consider this patch ok to >> > be commited. Some will be updated, other simply removed. >> > >> > I did not run benchmarks, but I feel like it speeds up php a bit :) >> > >> > Comments and feedbacks welcome, >> >>Still welcome... >> >>The patch includes now: >>- the all tests fixes (session) >> * tests being useless now are skiped (to allow review, will removed >> later) >>- functions removed: >> * session_register >> * session_unregister >> * session_is_registered >> They need register_globals to work >> >>I will wait until wednesday for feedbacks or objections, and commit on >>thursday. >> >>--Pierre >> >>-- >>PHP Internals - PHP Runtime Development Mailing List >>To unsubscribe, visit: http://www.php.net/unsub.php