Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22150 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42662 invoked by uid 1010); 6 Mar 2006 23:38:39 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 42647 invoked from network); 6 Mar 2006 23:38:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Mar 2006 23:38:39 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:27824] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id E5/B6-22029-CF7CC044 for ; Mon, 06 Mar 2006 18:38:37 -0500 Received: (qmail 3384 invoked from network); 6 Mar 2006 23:38:32 -0000 Received: from localhost (HELO zeev-notebook.zend.com) (127.0.0.1) by localhost with SMTP; 6 Mar 2006 23:38:32 -0000 Message-ID: <7.0.1.0.2.20060307013655.0c0064a8@zend.com> X-Mailer: QUALCOMM Windows Eudora Version 7.0.1.0 Date: Tue, 07 Mar 2006 01:38:34 +0200 To: pierre.php@gmail.com Cc: internals@lists.php.net In-Reply-To: <20060306214619.5e6ec076@localhost.localdomain> References: <20060305162128.5b1fdb86@localhost.localdomain> <20060306214619.5e6ec076@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Re: Adieu register_globals From: zeev@zend.com (Zeev Suraski) A part of the decision was to supply the few lines of code necessary to emulate register_globals in userspace. Volunteers? :) Zeev At 22:46 06/03/2006, Pierre wrote: >On Sun, 5 Mar 2006 16:21:28 +0100 >pierre.php@gmail.com (Pierre) wrote: > > > Hello, > > > > As discussed last year, register_globals will be removed in php6. This > > patch is the first step: > > > > http://pear.php.net/~pierre/remove_register_globals.txt > > > > The only thing I find confusing is a comment in main/php_variables.c > > php_autoglobal_merge. The comment says something and the tests > > something else (register_globals AND instead of register_globals OR). > > I will review all the affected tests if you consider this patch ok to > > be commited. Some will be updated, other simply removed. > > > > I did not run benchmarks, but I feel like it speeds up php a bit :) > > > > Comments and feedbacks welcome, > >Still welcome... > >The patch includes now: >- the all tests fixes (session) > * tests being useless now are skiped (to allow review, will removed > later) >- functions removed: > * session_register > * session_unregister > * session_is_registered > They need register_globals to work > >I will wait until wednesday for feedbacks or objections, and commit on >thursday. > >--Pierre > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php