Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22148 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89086 invoked by uid 1010); 6 Mar 2006 21:42:16 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 89071 invoked from network); 6 Mar 2006 21:42:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Mar 2006 21:42:16 -0000 X-Host-Fingerprint: 216.145.54.171 mrout1.yahoo.com FreeBSD 4.7-5.2 (or MacOS X 10.2-10.3) (2) Received: from ([216.145.54.171:30365] helo=mrout1.yahoo.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id F9/9F-22029-7BCAC044 for ; Mon, 06 Mar 2006 16:42:15 -0500 Received: from [66.228.175.145] (borndress-lm.corp.yahoo.com [66.228.175.145]) by mrout1.yahoo.com (8.13.4/8.13.4/y.out) with ESMTP id k26Le9vC017242; Mon, 6 Mar 2006 13:40:09 -0800 (PST) In-Reply-To: <20060306214619.5e6ec076@localhost.localdomain> References: <20060305162128.5b1fdb86@localhost.localdomain> <20060306214619.5e6ec076@localhost.localdomain> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-ID: <8b0e0064e75e5a52f5f10720f873722e@gravitonic.com> Content-Transfer-Encoding: 7bit Cc: internals@lists.php.net Date: Mon, 6 Mar 2006 13:41:57 -0800 To: pierre.php@gmail.com X-Mailer: Apple Mail (2.623) Subject: Re: [PHP-DEV] Re: Adieu register_globals From: andrei@gravitonic.com (Andrei Zmievski) Pierre, I think you should apply it. Kill the f***ing thing. -Andrei On Mar 6, 2006, at 12:46 PM, Pierre wrote: > On Sun, 5 Mar 2006 16:21:28 +0100 > pierre.php@gmail.com (Pierre) wrote: > >> Hello, >> >> As discussed last year, register_globals will be removed in php6. This >> patch is the first step: >> >> http://pear.php.net/~pierre/remove_register_globals.txt >> >> The only thing I find confusing is a comment in main/php_variables.c >> php_autoglobal_merge. The comment says something and the tests >> something else (register_globals AND instead of register_globals OR). >> I will review all the affected tests if you consider this patch ok to >> be commited. Some will be updated, other simply removed. >> >> I did not run benchmarks, but I feel like it speeds up php a bit :) >> >> Comments and feedbacks welcome, > > Still welcome... > > The patch includes now: > - the all tests fixes (session) > * tests being useless now are skiped (to allow review, will removed > later) > - functions removed: > * session_register > * session_unregister > * session_is_registered > They need register_globals to work > > I will wait until wednesday for feedbacks or objections, and commit on > thursday. > > --Pierre > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php