Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22147 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51258 invoked by uid 1010); 6 Mar 2006 20:49:54 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 51242 invoked from network); 6 Mar 2006 20:49:54 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Mar 2006 20:49:54 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:59267] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 1D/69-22029-270AC044 for ; Mon, 06 Mar 2006 15:49:54 -0500 Received: from [192.168.1.3] (dslb-084-063-041-017.pools.arcor-ip.net [84.63.41.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 4829C35C1CE; Mon, 6 Mar 2006 21:49:50 +0100 (CET) Date: Mon, 6 Mar 2006 21:50:01 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <191830324.20060306215001@marcus-boerger.de> To: Pierre Cc: internals@lists.php.net In-Reply-To: <20060306214619.5e6ec076@localhost.localdomain> References: <20060305162128.5b1fdb86@localhost.localdomain> <20060306214619.5e6ec076@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: Adieu register_globals From: helly@php.net (Marcus Boerger) Hello Pierre, looks even better becuase it includes the next two steps after your first patch. If it was up to me, i'd say just apply. marcus Monday, March 6, 2006, 9:46:19 PM, you wrote: > On Sun, 5 Mar 2006 16:21:28 +0100 > pierre.php@gmail.com (Pierre) wrote: >> Hello, >> >> As discussed last year, register_globals will be removed in php6. This >> patch is the first step: >> >> http://pear.php.net/~pierre/remove_register_globals.txt >> >> The only thing I find confusing is a comment in main/php_variables.c >> php_autoglobal_merge. The comment says something and the tests >> something else (register_globals AND instead of register_globals OR). >> I will review all the affected tests if you consider this patch ok to >> be commited. Some will be updated, other simply removed. >> >> I did not run benchmarks, but I feel like it speeds up php a bit :) >> >> Comments and feedbacks welcome, > Still welcome... > The patch includes now: > - the all tests fixes (session) > * tests being useless now are skiped (to allow review, will removed > later) > - functions removed: > * session_register > * session_unregister > * session_is_registered > They need register_globals to work > I will wait until wednesday for feedbacks or objections, and commit on > thursday. > --Pierre Best regards, Marcus