Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:22123 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7994 invoked by uid 1010); 5 Mar 2006 15:31:02 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 7979 invoked from network); 5 Mar 2006 15:31:02 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Mar 2006 15:31:02 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:55823] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 17/2B-22029-5340B044 for ; Sun, 05 Mar 2006 10:31:02 -0500 Received: from [192.168.1.3] (dslb-084-063-027-114.pools.arcor-ip.net [84.63.27.114]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 02B6735C1BD; Sun, 5 Mar 2006 16:30:57 +0100 (CET) Date: Sun, 5 Mar 2006 16:31:05 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <506024243.20060305163105@marcus-boerger.de> To: Pierre Cc: internals@lists.php.net In-Reply-To: <20060305162128.5b1fdb86@localhost.localdomain> References: <20060305162128.5b1fdb86@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Adieu register_globals From: helly@php.net (Marcus Boerger) Hello Pierre, Sunday, March 5, 2006, 4:21:28 PM, you wrote: > Hello, > As discussed last year, register_globals will be removed in php6. This > patch is the first step: > http://pear.php.net/~pierre/remove_register_globals.txt > The only thing I find confusing is a comment in main/php_variables.c > php_autoglobal_merge. The comment says something and the tests > something else (register_globals AND instead of register_globals OR). I > will review all the affected tests if you consider this patch ok to be > commited. Some will be updated, other simply removed. > I did not run benchmarks, but I feel like it speeds up php a bit :) I see the same. > Comments and feedbacks welcome, "Wipe them out - *all* of them" just as discussed. But take care of the tests first. Best regards, Marcus