Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:21997 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 69716 invoked by uid 1010); 24 Feb 2006 14:16:05 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 69700 invoked from network); 24 Feb 2006 14:16:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Feb 2006 14:16:05 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:57580] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 09/BF-30574-4251FF34 for ; Fri, 24 Feb 2006 09:16:04 -0500 Received: from [192.168.1.3] (dslb-084-063-048-025.pools.arcor-ip.net [84.63.48.25]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 2E61235C1BF; Fri, 24 Feb 2006 15:16:00 +0100 (CET) Date: Fri, 24 Feb 2006 15:16:00 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1655307513.20060224151600@marcus-boerger.de> To: Steph Fox Cc: internals In-Reply-To: <047e01c6394b$56b54ad0$6402a8c0@foxbox> References: <047e01c6394b$56b54ad0$6402a8c0@foxbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] kill a few compiler warnings in 5_1 branch From: helly@php.net (Marcus Boerger) Hello Steph, a few minor corrections to your patch, can you send the full patch in one file? best regards marcus Friday, February 24, 2006, 3:05:15 PM, you wrote: > Index: Zend/zend_vm_execute.h > =================================================================== > RCS file: /repository/ZendEngine2/zend_vm_execute.h,v > retrieving revision 1.62.2.24 > diff -u -r1.62.2.24 zend_vm_execute.h > --- Zend/zend_vm_execute.h 6 Feb 2006 11:45:56 -0000 1.62.2.24 > +++ Zend/zend_vm_execute.h 24 Feb 2006 01:27:44 -0000 > @@ -7553,7 +7553,7 @@ > HashTable *fe_ht; > zend_object_iterator *iter = NULL; > int key_type; > - zend_bool use_key = opline->extended_value & ZEND_FE_FETCH_WITH_KEY; > + zend_bool use_key = (zend_bool)opline->extended_value & ZEND_FE_FETCH_WITH_KEY; + zend_bool use_key = (zend_bool)(opline->extended_value & ZEND_FE_FETCH_WITH_KEY); > > PZVAL_LOCK(array); > >Index: ext/com_dotnet/com_saproxy.c >=================================================================== >RCS file: /repository/php-src/ext/com_dotnet/com_saproxy.c,v >retrieving revision 1.15.2.2 >diff -u -r1.15.2.2 com_saproxy.c >--- ext/com_dotnet/com_saproxy.c 1 Jan 2006 12:50:00 -0000 1.15.2.2 >+++ ext/com_dotnet/com_saproxy.c 24 Feb 2006 00:34:20 -0000 >@@ -160,7 +160,7 @@ > return return_value; > } > >- if (dims - 1 == proxy->dimensions) { >+ if ((int)dims - 1 == proxy->dimensions) { + if ((int)(dims - 1) == proxy->dimensions) { > LONG *indices; > VARTYPE vt; > VARIANT v; >Index: ext/standard/array.c >=================================================================== >RCS file: /repository/php-src/ext/standard/array.c,v >retrieving revision 1.308.2.17 >diff -u -r1.308.2.17 array.c >--- ext/standard/array.c 7 Feb 2006 17:54:24 -0000 1.308.2.17 >+++ ext/standard/array.c 24 Feb 2006 12:41:17 -0000 >@@ -1810,14 +1810,14 @@ > /* Clamp the offset.. */ > if (offset > num_in) > offset = num_in; >- else if (offset < 0 && (offset=num_in+offset) < 0) >+ else if (offset < 0 && (offset = num_in + offset) < 0) + else if (offset < 0 && (offset = (num_in + offset)) < 0) > offset = 0; > > /* ..and the length */ > if (length < 0) { >- length = num_in-offset+length; >- } else if (((unsigned) offset + (unsigned) length) > num_in) { >- length = num_in-offset; >+ length = num_in - offset + length; >+ } else if (((unsigned)offset + (unsigned)length) > (unsigned)num_in) { >+ length = num_in - offset; > } > > /* Create and initialize output hash */ >@@ -2204,14 +2204,14 @@ > /* Clamp the offset.. */ > if (offset_val > num_in) > return; >- else if (offset_val < 0 && (offset_val=num_in+offset_val) < 0) >+ else if (offset_val < 0 && (offset_val = num_in + offset_val) < 0) + else if (offset_val < 0 && (offset_val = (num_in + offset_val)) < 0) > offset_val = 0; > > /* ..and the length */ > if (length_val < 0) { >- length_val = num_in-offset_val+length_val; >- } else if (((unsigned) offset_val + (unsigned) length_val) > num_in) { >- length_val = num_in-offset_val; >+ length_val = num_in - offset_val + length_val; >+ } else if (((unsigned)offset_val + (unsigned)length_val) > (unsigned)num_in) { >+ length_val = num_in - offset_val; > } > > if (length_val == 0) Best regards, Marcus