Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:21864 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 15952 invoked by uid 1010); 13 Feb 2006 19:56:07 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 15937 invoked from network); 13 Feb 2006 19:56:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Feb 2006 19:56:07 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:53497] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id D9/10-14729-654E0F34 for ; Mon, 13 Feb 2006 14:56:07 -0500 Received: from [192.168.1.3] (dslb-084-063-033-253.pools.arcor-ip.net [84.63.33.253]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id B8E2A35C011; Mon, 13 Feb 2006 20:56:02 +0100 (CET) Date: Mon, 13 Feb 2006 20:54:36 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <643979025.20060213205436@marcus-boerger.de> To: Andrei Zmievski Cc: Brion Vibber , internals@lists.php.net In-Reply-To: <3e00b5046e86aa205a072001a84b4e16@gravitonic.com> References: <43F04C6E.9070409@pobox.com> <847478720.20060213102018@marcus-boerger.de> <3e00b5046e86aa205a072001a84b4e16@gravitonic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] unicode_semantics "off" evaluates to true From: helly@php.net (Marcus Boerger) Hello Andrei, changed to unicode_semantics() now. thanks for the hint. best regards marcus Monday, February 13, 2006, 6:26:13 PM, you wrote: > I don't think it's right to call it unicode_enabled(). Unicode is > always accessible, it's just that certain language semantics don't use > it when unicode_semantics is off. So I'd call the function > unicode_semantics() or unicode_default(). > -Andrei > On Feb 13, 2006, at 1:20 AM, Marcus Boerger wrote: >> Hello Brion, >> >> i applied your fix which was correct. I however also added a >> function to >> check for unicode mode "bool unicode_enabled()" which returns true if >> unicode_semantics is set true. >> >> best regards >> marcus >> >> Monday, February 13, 2006, 10:07:58 AM, you wrote: >> >>> Index: Zend/zend.c >>> =================================================================== >>> RCS file: /repository/ZendEngine2/zend.c,v >>> retrieving revision 1.333 >>> diff -u -r1.333 zend.c >>> --- Zend/zend.c 8 Feb 2006 18:52:13 -0000 1.333 >>> +++ Zend/zend.c 13 Feb 2006 08:53:35 -0000 >>> @@ -197,7 +197,7 @@ >>> STD_ZEND_INI_BOOLEAN("zend.ze1_compatibility_mode", "0", >>> ZEND_INI_ALL, OnUpdateBool, ze1_compatibility_mode, >>> zend_executor_globals, executor_globals) >>> >>> /* Unicode .ini entries */ >>> - STD_ZEND_INI_ENTRY("unicode_semantics", "off", >>> ZEND_INI_SYSTEM, >>> OnUpdateBool, unicode, zend_unicode_globals, unicode_globals) >>> + STD_ZEND_INI_BOOLEAN("unicode_semantics", "0", >>> ZEND_INI_SYSTEM, >>> OnUpdateBool, unicode, zend_unicode_globals, unicode_globals) >>> STD_ZEND_INI_ENTRY("unicode.fallback_encoding", NULL, >>> ZEND_INI_ALL, OnUpdateEncoding, fallback_encoding_conv, >>> zend_unicode_globals, unicode_globals) >>> STD_ZEND_INI_ENTRY("unicode.runtime_encoding", NULL, >>> ZEND_INI_ALL, OnUpdateEncoding, runtime_encoding_conv, >>> zend_unicode_globals, unicode_globals) >>> STD_ZEND_INI_ENTRY("unicode.script_encoding", NULL, >>> ZEND_INI_ALL, OnUpdateEncoding, script_encoding_conv, >>> zend_unicode_globals, unicode_globals)