Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:21863 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 55972 invoked by uid 1010); 13 Feb 2006 17:25:39 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 55951 invoked from network); 13 Feb 2006 17:25:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Feb 2006 17:25:39 -0000 X-Host-Fingerprint: 216.145.54.171 mrout1.yahoo.com FreeBSD 4.7-5.2 (or MacOS X 10.2-10.3) (2) Received: from ([216.145.54.171:46009] helo=mrout1.yahoo.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id E9/22-42162-111C0F34 for ; Mon, 13 Feb 2006 12:25:38 -0500 Received: from [66.228.175.145] (borndress-lm.corp.yahoo.com [66.228.175.145]) by mrout1.yahoo.com (8.13.4/8.13.4/y.out) with ESMTP id k1DHOdYU028370; Mon, 13 Feb 2006 09:24:39 -0800 (PST) In-Reply-To: <847478720.20060213102018@marcus-boerger.de> References: <43F04C6E.9070409@pobox.com> <847478720.20060213102018@marcus-boerger.de> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-ID: <3e00b5046e86aa205a072001a84b4e16@gravitonic.com> Content-Transfer-Encoding: 7bit Cc: Brion Vibber , internals@lists.php.net Date: Mon, 13 Feb 2006 09:26:13 -0800 To: Marcus Boerger X-Mailer: Apple Mail (2.623) Subject: Re: [PHP-DEV] [PATCH] unicode_semantics "off" evaluates to true From: andrei@gravitonic.com (Andrei Zmievski) I don't think it's right to call it unicode_enabled(). Unicode is always accessible, it's just that certain language semantics don't use it when unicode_semantics is off. So I'd call the function unicode_semantics() or unicode_default(). -Andrei On Feb 13, 2006, at 1:20 AM, Marcus Boerger wrote: > Hello Brion, > > i applied your fix which was correct. I however also added a > function to > check for unicode mode "bool unicode_enabled()" which returns true if > unicode_semantics is set true. > > best regards > marcus > > Monday, February 13, 2006, 10:07:58 AM, you wrote: > >> Index: Zend/zend.c >> =================================================================== >> RCS file: /repository/ZendEngine2/zend.c,v >> retrieving revision 1.333 >> diff -u -r1.333 zend.c >> --- Zend/zend.c 8 Feb 2006 18:52:13 -0000 1.333 >> +++ Zend/zend.c 13 Feb 2006 08:53:35 -0000 >> @@ -197,7 +197,7 @@ >> STD_ZEND_INI_BOOLEAN("zend.ze1_compatibility_mode", "0", >> ZEND_INI_ALL, OnUpdateBool, ze1_compatibility_mode, >> zend_executor_globals, executor_globals) >> >> /* Unicode .ini entries */ >> - STD_ZEND_INI_ENTRY("unicode_semantics", "off", >> ZEND_INI_SYSTEM, >> OnUpdateBool, unicode, zend_unicode_globals, unicode_globals) >> + STD_ZEND_INI_BOOLEAN("unicode_semantics", "0", >> ZEND_INI_SYSTEM, >> OnUpdateBool, unicode, zend_unicode_globals, unicode_globals) >> STD_ZEND_INI_ENTRY("unicode.fallback_encoding", NULL, >> ZEND_INI_ALL, OnUpdateEncoding, fallback_encoding_conv, >> zend_unicode_globals, unicode_globals) >> STD_ZEND_INI_ENTRY("unicode.runtime_encoding", NULL, >> ZEND_INI_ALL, OnUpdateEncoding, runtime_encoding_conv, >> zend_unicode_globals, unicode_globals) >> STD_ZEND_INI_ENTRY("unicode.script_encoding", NULL, >> ZEND_INI_ALL, OnUpdateEncoding, script_encoding_conv, >> zend_unicode_globals, unicode_globals) > > > > > Best regards, > Marcus > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php