Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:21852
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <43F04C6E.9070409@pobox.com>
Date: Mon, 13 Feb 2006 01:07:58 -0800
User-Agent: Thunderbird 1.5 (Macintosh/20051201)
MIME-Version: 1.0
To: internals@lists.php.net
Content-Type: multipart/mixed;
	boundary="------------040502070907090505010505"
Subject: [PATCH] unicode_semantics "off" evaluates to true
From: brion@pobox.com (Brion Vibber)

--------------040502070907090505010505
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

I've started cautiously poking PHP 6 so I can keep an eye on how the Unicode
support is going and see what kind of work we'll eventually need to do to port
MediaWiki for it...

One thing I noticed right off is that this test doesn't do what you'd expect if
you didn't copy in one of the sample php.ini files:

if(ini_get("unicode_semantics")) { /* bla bla */ }

The default value for unicode_semantics is the literal string "off", which
evaluates to true although the setting really is off.

Attached is a one-line patch which sets it to "0" and uses the macro
STD_ZEND_INI_BOOLEAN, to match with other config settings I saw in there. This
keeps it off by default but makes the ini_get evaluate to the expected false in
a boolean test.

- -- brion vibber (brion @ pobox.com)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFD8ExuwRnhpk1wk44RAir6AKCPFd4tVpGJ8a0a/L2COvrQoiKnqQCgqAkY
h5b6AbfY40TfQKPnRHO7xv0=
=P8dd
-----END PGP SIGNATURE-----

--------------040502070907090505010505
Content-Type: text/plain; x-mac-type="0"; x-mac-creator="0";
 name="ini-unicode_semantics-bool.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ini-unicode_semantics-bool.diff"

Index: Zend/zend.c
===================================================================
RCS file: /repository/ZendEngine2/zend.c,v
retrieving revision 1.333
diff -u -r1.333 zend.c
--- Zend/zend.c	8 Feb 2006 18:52:13 -0000	1.333
+++ Zend/zend.c	13 Feb 2006 08:53:35 -0000
@@ -197,7 +197,7 @@
 	STD_ZEND_INI_BOOLEAN("zend.ze1_compatibility_mode",	"0",	ZEND_INI_ALL,		OnUpdateBool,	ze1_compatibility_mode,	zend_executor_globals,	executor_globals)
 
 	/* Unicode .ini entries */
-	STD_ZEND_INI_ENTRY("unicode_semantics", "off", ZEND_INI_SYSTEM, OnUpdateBool, unicode, zend_unicode_globals, unicode_globals)
+	STD_ZEND_INI_BOOLEAN("unicode_semantics", "0", ZEND_INI_SYSTEM, OnUpdateBool, unicode, zend_unicode_globals, unicode_globals)
 	STD_ZEND_INI_ENTRY("unicode.fallback_encoding", NULL, ZEND_INI_ALL, OnUpdateEncoding,   fallback_encoding_conv, zend_unicode_globals, unicode_globals)
 	STD_ZEND_INI_ENTRY("unicode.runtime_encoding",  NULL, ZEND_INI_ALL, OnUpdateEncoding,   runtime_encoding_conv, zend_unicode_globals, unicode_globals)
 	STD_ZEND_INI_ENTRY("unicode.script_encoding",  NULL, ZEND_INI_ALL, OnUpdateEncoding,   script_encoding_conv, zend_unicode_globals, unicode_globals)

--------------040502070907090505010505--