Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:21726
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <43DD2D20.5010001@php.net>
Date: Sun, 29 Jan 2006 22:01:20 +0100
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
MIME-Version: 1.0
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: zend_hash.c fishy code
From: sesser@php.net (Stefan Esser)

Good Morning,

I wonder If I am completely missing the point, but the following piece
of code seems fishy to me:

ZEND_API int zend_hash_del_key_or_index(HashTable *ht, char *arKey, uint
nKeyLength, ulong h, int flag)
{
        uint nIndex;
        Bucket *p;

       ...

        while (p != NULL) {
                if ((p->h == h) && ((p->nKeyLength == 0) || /* Numeric
index */
                        ((p->nKeyLength == nKeyLength) &&
(!memcmp(p->arKey, arKey, nKeyLength))))) {
                        HANDLE_BLOCK_INTERRUPTIONS();
                         ...

If I am not completely mistaken this means: If this is a bucket with a
numeric index with the hash value of the key we want to delete, then
delete it, even when we wanted to delete a key with a string as index.

Stefan