Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:21618 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 76039 invoked by uid 1010); 21 Jan 2006 12:49:09 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 76024 invoked from network); 21 Jan 2006 12:49:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Jan 2006 12:49:09 -0000 X-Host-Fingerprint: 82.94.239.5 jdi.jdi-ict.nl Linux 2.5 (sometimes 2.4) (4) Received: from ([82.94.239.5:45042] helo=jdi.jdi-ict.nl) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 04/9F-10117-3CD22D34 for ; Sat, 21 Jan 2006 07:49:08 -0500 Received: from localhost (localhost [127.0.0.1]) by jdi.jdi-ict.nl (8.12.11/8.12.11) with ESMTP id k0LCmtkk027712; Sat, 21 Jan 2006 13:48:55 +0100 Received: from localhost (localhost [127.0.0.1]) by jdi.jdi-ict.nl (8.12.11/8.12.11) with ESMTP id k0LCmqrN027706; Sat, 21 Jan 2006 13:48:52 +0100 Date: Sat, 21 Jan 2006 13:48:54 +0100 (CET) X-X-Sender: derick@localhost To: Jani Taskinen cc: Andi Gutmans , Rasmus Lerdorf , internals@lists.php.net In-Reply-To: Message-ID: References: <43D13AAE.1030409@lerdorf.com> <7.0.0.16.2.20060120134701.04186f60@zend.com> <7.0.0.16.2.20060120160835.040c9f20@zend.com> <7.0.0.16.2.20060120165840.041fbf10@zend.com> <43D19937.6050201@lerdorf.com> <7.0.0.16.2.20060120183001.0421da58@zend.com> X-Face: "L'&?Ah3MYF@FB4hU'XhNhLB]222(Lbr2Y@F:GE[OO;"F5p>qtFBl|yVVA&D{A(g3[C}mG:199P+5C'v.M/u@Z\![0b:Mv.[l6[uWl' MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdi-ict.nl Subject: Re: [PHP-DEV] Filter extension inclusion in core (was: Re: [PHP-DEV] JSON inclusion in core) From: derick@php.net (Derick Rethans) On Sat, 21 Jan 2006, Jani Taskinen wrote: > On Fri, 20 Jan 2006, Andi Gutmans wrote: > > Not sure about the functionality, and I agree some of it can probably way, > > but > > Way..wait? :) > > > I would want to finalize the naming before so that we don't have to change > > it and have another BC mode. > > If the naming is the only problem, I can fix that in a minute. > And only thing needing any renaming are these (with my proposal): > > FS_ and FL_ => FILTER_TYPE_ (IMO it's not necessary to separate these) It is, because there's both a sanitizing and validation filter for email and url. > FC_CALLBACK => FILTER_CALLBACK (there's just one) I changed in CVS as follows: FL_* -> FILTER_VLIDATE_* FS_* -> FILTER_SANITIZE_* (except: FS_UNSAFE_RAW to FILTER_UNSAFE_RAW FS_DEFAULT to FILTER_DEFAULT ) FC_CALLBACK -> FILTER_CALLBACK I also commented out the registering of all the FL and FS constants into PHP, as you should use the name of the filter and not this constant. regards, Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org