Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:21464 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94820 invoked by uid 1010); 10 Jan 2006 19:38:01 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 94804 invoked from network); 10 Jan 2006 19:38:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 10 Jan 2006 19:38:00 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:52383] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id EE/F5-27796-71D04C34 for ; Tue, 10 Jan 2006 14:38:00 -0500 Received: (qmail 9290 invoked from network); 10 Jan 2006 19:37:55 -0000 Received: from internal.zend.office (HELO ?127.0.0.1?) (10.1.1.1) by internal.zend.office with SMTP; 10 Jan 2006 19:37:55 -0000 Message-ID: <43C40D11.6020001@zend.com> Date: Tue, 10 Jan 2006 22:37:53 +0300 User-Agent: Thunderbird 1.5 (X11/20051025) MIME-Version: 1.0 To: Thiago Silva CC: internals@lists.php.net References: <200601101613.02531.thiago.silva@kdemail.net> In-Reply-To: <200601101613.02531.thiago.silva@kdemail.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] entry #35269 From: antony@zend.com (Antony Dovgal) On 10.01.2006 19:13, Thiago Silva wrote: > Hi, > can anyone review this? > > It's a one-line patch for the silent operator (@), wich currently supress > fatal error messages (undesirable for "@include" pehaps, wich makes difficult > for debugging scripts). With this patch you basically change whole @ functionality, thus breaking both BC and expected behavior in the same time. And even in the case with include() - this is _expected_. If you don't want to see all error messages silenced, just use set_error_reporting() to set desired error level. > Index: Zend/zend_vm_execute.h > =================================================================== > RCS file: /repository/ZendEngine2/zend_vm_execute.h,v > retrieving revision 1.62.2.23 > diff -u -r1.62.2.23 zend_vm_execute.h > --- Zend/zend_vm_execute.h 4 Jan 2006 23:53:04 -0000 1.62.2.23 > +++ Zend/zend_vm_execute.h 10 Jan 2006 18:01:53 -0000 > @@ -434,7 +434,8 @@ > } > > if (EG(error_reporting)) { > - zend_alter_ini_entry("error_reporting", sizeof("error_reporting"), "0", 1, ZEND_INI_USER, ZEND_INI_STAGE_RUNTIME); > + /* 341 == E_COMPILE_ERROR|E_ERROR|E_CORE_ERROR|E_PARSE|E_USER_ERROR */ > + zend_alter_ini_entry("error_reporting", sizeof("error_reporting"), "341", 3, ZEND_INI_USER, ZEND_INI_STAGE_RUNTIME); > } > ZEND_VM_NEXT_OPCODE(); > } -- Wbr, Antony Dovgal