Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:21377 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 46811 invoked by uid 1010); 3 Jan 2006 22:09:52 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 46796 invoked from network); 3 Jan 2006 22:09:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 3 Jan 2006 22:09:52 -0000 X-Host-Fingerprint: 192.38.9.232 gw2.emini.dk Linux 2.4/2.6 Received: from ([192.38.9.232:3622] helo=gw2.emini.dk) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 4E/3B-34518-E26FAB34 for ; Tue, 03 Jan 2006 17:09:50 -0500 Received: from foxbox (IGLD-84-228-50-112.inter.net.il [84.228.50.112]) by gw2.emini.dk (Postfix) with ESMTP id DD9C09BD1E for ; Tue, 3 Jan 2006 23:09:44 +0100 (CET) Message-ID: <03f001c610b2$681138a0$6402a8c0@foxbox> Reply-To: "Steph Fox" To: "internals" References: <032b01c61092$1951d1e0$6402a8c0@foxbox> Date: Wed, 4 Jan 2006 00:09:44 +0200 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_03ED_01C610C3.2A934700" X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2180 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2180 Subject: Re: [PHP-DEV] Fw: interesting buglet [PATCH] From: steph@zend.com ("Steph Fox") ------=_NextPart_000_03ED_01C610C3.2A934700 Content-Type: text/plain; format=flowed; charset="Windows-1252"; reply-type=response Content-Transfer-Encoding: 7bit No it didn't take me that long, I was busy writing stuff... The test suite copes with this, I can't see a reason for it to break anything. If it goes into HEAD, can it also go into 5_1 please? - Steph (ps ws fixes for zend_compile.c attached also). ----- Original Message ----- From: "Steph Fox" To: "internals" Sent: Tuesday, January 03, 2006 8:18 PM Subject: [PHP-DEV] Fw: interesting buglet > Hi all, > > Not quite sure who actually implemented E_STRICT, but it doesn't take > notice of internal vs userland classes. See below. (and let me know if I > need to open a bug report.) > > - Steph > > ----- Original Message ----- > From: "Andrei Zmievski" > To: "Steph Fox" > Cc: "PHP-GTK dev" > Sent: Tuesday, January 03, 2006 8:13 PM > Subject: Re: interesting buglet > > >> Ask the person who implemented that warning, perhaps? >> >> -Andrei >> >> On Jan 3, 2006, at 10:02 AM, Steph Fox wrote: >> >>> Hey Andrei, >>> >>> I was debugging something completely unrelated (PHP stuff) and left >>> display_startup_errors = 1 in the php.ini I use for PHP-GTK 2. >>> >>> Get this: >>> >>> C:\php5>php -v >>> >>> Strict Standards: Declaration of GtkToolbar::set_style() should be >>> compatible with that of GtkWidget::set_style() in Unknown on line 0 >>> >>> Strict Standards: Declaration of GtkMenu::set_accel_path() should be >>> compatible with that of GtkWidget::set_accel_path() in Unknown on line 0 >>> >>> Strict Standards: Declaration of GtkWindow::mnemonic_activate() should >>> be compatible with that of GtkWidget::mnemonic_activate() in Unknown on >>> line 0 >>> >>> Strict Standards: Declaration of GtkMenuItem::set_accel_path() should be >>> compatible with that of GtkWidget::set_accel_path() in Unknown on line 0 >>> >>> Strict Standards: Declaration of GtkStatusbar::remove() should be >>> compatible with that of GtkContainer::remove() in Unknown on line 0 >>> >>> Strict Standards: Declaration of GtkCList::remove() should be compatible >>> with that of GtkContainer::remove() in Unknown on line 0 >>> >>> Strict Standards: Declaration of GtkComboBoxEntry::new_with_model() >>> should be compatible with that of GtkComboBox::new_with_model() in >>> Unknown on line 0 >>> PHP 5.1.2RC2-dev (cli) (built: Jan 3 2006 00:05:59) >>> Copyright (c) 1997-2006 The PHP Group >>> Zend Engine v2.1.0, Copyright (c) 1998-2005 Zend Technologies >>> >>> Guess we need to force display_startup_errors = 0? Or is there some way >>> to make PHP know these are internal classes? >>> >>> - Steph >> >> >> __________ NOD32 1.1350 (20060103) Information __________ >> >> This message was checked by NOD32 antivirus system. >> http://www.eset.com >> >> > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > > __________ NOD32 1.1350 (20060103) Information __________ > > This message was checked by NOD32 antivirus system. > http://www.eset.com > > ------=_NextPart_000_03ED_01C610C3.2A934700 Content-Type: text/plain; format=flowed; name="internal_class.txt"; reply-type=response Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="internal_class.txt" Index: ZendEngine2/zend_compile.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /repository/ZendEngine2/zend_compile.c,v=0A= retrieving revision 1.676=0A= diff -u -r1.676 zend_compile.c=0A= --- ZendEngine2/zend_compile.c 17 Dec 2005 15:50:24 -0000 1.676=0A= +++ ZendEngine2/zend_compile.c 3 Jan 2006 22:02:10 -0000=0A= @@ -2009,6 +2009,10 @@=0A= {=0A= zend_uint i;=0A= =0A= + if (fe->common.type =3D=3D ZEND_INTERNAL_CLASS) {=0A= + return 1;=0A= + }=0A= +=0A= /* If it's a user function then arg_info =3D=3D NULL means we don't = have any parameters but we still need to do the arg number checks. We = are only willing to ignore this for internal functions because = extensions don't always define arg_info. */=0A= if (!proto || (!proto->common.arg_info && proto->common.type !=3D = ZEND_USER_FUNCTION)) {=0A= return 1;=0A= =0A= ------=_NextPart_000_03ED_01C610C3.2A934700 Content-Type: text/plain; format=flowed; name="ws.txt"; reply-type=response Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="ws.txt" Index: ZendEngine2/zend_compile.c=0A= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= RCS file: /repository/ZendEngine2/zend_compile.c,v=0A= retrieving revision 1.676=0A= diff -u -r1.676 zend_compile.c=0A= --- ZendEngine2/zend_compile.c 17 Dec 2005 15:50:24 -0000 1.676=0A= +++ ZendEngine2/zend_compile.c 3 Jan 2006 21:59:26 -0000=0A= @@ -2973,7 +2973,7 @@=0A= {=0A= char *prop_name;=0A= int prop_name_length;=0A= - =0A= +=0A= prop_name_length =3D 1 + src1_length + 1 + src2_length;=0A= prop_name =3D pemalloc(prop_name_length + 1, internal);=0A= prop_name[0] =3D '\0';=0A= @@ -3118,9 +3118,9 @@=0A= zend_op opline;=0A= zend_llist *fetch_list_ptr;=0A= zend_op *opline_ptr=3DNULL;=0A= - =0A= +=0A= zend_stack_top(&CG(bp_stack), (void **) &fetch_list_ptr);=0A= - =0A= +=0A= if (fetch_list_ptr->count =3D=3D 1) {=0A= zend_llist_element *le;=0A= =0A= ------=_NextPart_000_03ED_01C610C3.2A934700--