Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:21279
Return-Path: <kingwez@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 67155 invoked by uid 1010); 19 Dec 2005 10:30:20 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 67140 invoked from network); 19 Dec 2005 10:30:20 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 19 Dec 2005 10:30:20 -0000
X-Host-Fingerprint: 64.233.184.202 wproxy.gmail.com Linux 2.4/2.6
Received: from ([64.233.184.202:28363] helo=wproxy.gmail.com)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id 55/03-14561-BBB86A34 for <internals@lists.php.net>; Mon, 19 Dec 2005 05:30:19 -0500
Received: by wproxy.gmail.com with SMTP id i24so1115753wra
	for <internals@lists.php.net>; Mon, 19 Dec 2005 02:30:16 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=nwoWQq4geKsijgqzTqaLirw81owcjYvaKR5tJdHNRDaZPwWdXr+kQmutHPj7fUJm2ksQZPePX5fA6mhCBIMkcNOjkC1h6W9RT5XDGLXs2rPUqg833Cw5X9OeBJIngA6Cm/YoltJQlhKS+J+2hmFuFP4KVsZgYOFW+/gd/nss8X8=
Received: by 10.54.68.7 with SMTP id q7mr451000wra;
	Mon, 19 Dec 2005 02:30:16 -0800 (PST)
Received: by 10.54.77.20 with HTTP; Mon, 19 Dec 2005 02:30:16 -0800 (PST)
Message-ID: <4e89b4260512190230l425f2a90ra1fd969921832f52@mail.gmail.com>
Date: Mon, 19 Dec 2005 05:30:16 -0500
To: Anish Mistry <mistry.7@osu.edu>
Cc: internals@lists.php.net
In-Reply-To: <200512190511.11835.mistry.7@osu.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <200512190511.11835.mistry.7@osu.edu>
Subject: Re: [PHP-DEV] STARTTLS support for SIEVE
From: kingwez@gmail.com (Wez Furlong)

You've patched this at the transport level; while that will work, it's
architecturally incorrect.
STARTTLS is a protocol level thing, so you code would be better suited
as a wrapper.
You can implement wrappers in user-space
(http://www.php.net/manual/en/function.stream-register-wrapper.php),
so you don't need to patch the C code.
In fact, you don't even need a wrapper for this functionality:

<?php
$s =3D fsockopen($host, $port);
// do capability negiotiation here
// ...
// now turn on crypto
stream_socket_enable_crypto($s, true,
      STREAM_CRYPTO_METHOD_TLS_CLIENT);
?>

--Wez.

On 12/19/05, Anish Mistry <mistry.7@osu.edu> wrote:
> Attached is a patch to enable (SIEVE) STARTTLS support for fsockopen
> using stls://host.example.org
> I'm pretty sure I've got it to conform to the RFC:
> http://www.holtmann.org/email/sieve/draft-martin-managesieve-03.txt
> Currently it only works with SIEVE, but it could be easily extended to
> do SMTP (Send "EHLO hostname" first) and IMAP.
> Maybe something like sieve+stls:// and smtp+stls:// would be better
> for the separate STARTTLS setups.
>
> http://am-productions.biz/docs/patch-openssl-starttls.patch
>
> I'm sure there are a bunch of things "wrong" with how I've done this,
> so feel free to send suggestions.
>
> Thanks,
> --
> Anish Mistry
>
>
>