Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:21216 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80173 invoked by uid 1010); 14 Dec 2005 12:11:51 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 80158 invoked from network); 14 Dec 2005 12:11:51 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Dec 2005 12:11:51 -0000 X-Host-Fingerprint: 195.197.172.115 gw01.mail.saunalahti.fi Linux 2.4/2.6 Received: from ([195.197.172.115:56306] helo=gw01.mail.saunalahti.fi) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 47/1A-49905-70C00A34 for ; Wed, 14 Dec 2005 07:11:51 -0500 Received: from nest.netphobia.fi (YZDCXXXI.dsl.saunalahti.fi [85.76.35.232]) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id E1BBF1035DD; Wed, 14 Dec 2005 14:11:41 +0200 (EET) Received: from nest.netphobia.fi (nest.netphobia.fi [127.0.0.1]) by nest.netphobia.fi (8.13.1/8.13.1) with ESMTP id jBECBghV026455; Wed, 14 Dec 2005 14:11:42 +0200 Received: from localhost (jani@localhost) by nest.netphobia.fi (8.13.1/8.13.1/Submit) with ESMTP id jBECBg4d026452; Wed, 14 Dec 2005 14:11:42 +0200 X-Authentication-Warning: nest.netphobia.fi: jani owned process doing -bs Date: Wed, 14 Dec 2005 14:11:42 +0200 (EET) Reply-To: Jani Taskinen To: Markus Fischer cc: John Coggeshall , Andi Gutmans , internals@lists.php.net, iliaa@php.net In-Reply-To: <43A00874.8000706@fischer.name> Message-ID: References: <42D78B4A.7080208@fischer.name> <42D78B4A.7080208@fischer.name> <5.1.0.14.2.20050715120049.02739670@localhost> <431602E7.5050500@fischer.name> <43A00874.8000706@fischer.name> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [PHP-DEV] [Patch] tidy node and getParent From: sniper@iki.fi (Jani Taskinen) If the patch was downloadable somewhere, I bet someone had already committed it. :) --Jani On Wed, 14 Dec 2005, Markus Fischer wrote: > > Hi, > > any chance for http://bugs.php.net/bug.php?id=34023 this time? > > thanks, > - Markus > > Markus Fischer wrote: >> Hi, >> >> can this be taken into consideration for HEAD now that RC1 is out of the >> door? >> >> thanks, >> - Markus >> >> Andi Gutmans wrote: >> >>> We're in a feature freeze so please hold it to after 5.1.0 is out the door. >>> You'll be able to commit to head when RC1 is branched off. >>> >>> Thanks, >>> Andi >>> >>> At 01:31 PM 7/15/2005 -0400, John Coggeshall wrote: >>> >>>> I'll take a look at it and commit if it looks good. >>>> >>>> John >>>> >>>> On Fri, 2005-07-15 at 12:09 +0200, Markus Fischer wrote: >>>> > Hi, >>>> > >>>> > attached is a patch to add the getParent() method for the tidyNode >>>> > against HEAD. >>>> > >>>> > It's just a quick patch for me. I don't know if all tidy version support >>>> > the getTidyParent function and if it's memory leak free so someone >>>> > should review it first. >>>> > >>>> > cheers, >>>> > - Markus >>>> > plain text document attachment (tidy_getParent.diff.txt) >>>> > ? tidy_getParent.diff.txt >>>> > Index: php_tidy.h >>>> > =================================================================== >>>> > RCS file: /repository/php-src/ext/tidy/php_tidy.h,v >>>> > retrieving revision 1.25 >>>> > diff -u -r1.25 php_tidy.h >>>> > --- php_tidy.h 25 Apr 2005 20:46:16 -0000 1.25 >>>> > +++ php_tidy.h 15 Jul 2005 09:59:44 -0000 >>>> > @@ -89,6 +89,7 @@ >>>> > TIDY_NODE_METHOD(isJste); >>>> > TIDY_NODE_METHOD(isAsp); >>>> > TIDY_NODE_METHOD(isPhp); >>>> > +TIDY_NODE_METHOD(getParent); >>>> > >>>> > ZEND_BEGIN_MODULE_GLOBALS(tidy) >>>> > char *default_config; >>>> > Index: tidy.c >>>> > =================================================================== >>>> > RCS file: /repository/php-src/ext/tidy/tidy.c,v >>>> > retrieving revision 1.65 >>>> > diff -u -r1.65 tidy.c >>>> > --- tidy.c 25 Apr 2005 20:46:16 -0000 1.65 >>>> > +++ tidy.c 15 Jul 2005 09:59:45 -0000 >>>> > @@ -291,6 +291,7 @@ >>>> > TIDY_NODE_ME(isJste, NULL) >>>> > TIDY_NODE_ME(isAsp, NULL) >>>> > TIDY_NODE_ME(isPhp, NULL) >>>> > + TIDY_NODE_ME(getParent, NULL) >>>> > {NULL, NULL, NULL} >>>> > }; >>>> > >>>> > @@ -1668,6 +1669,30 @@ >>>> > } >>>> > /* }}} */ >>>> > >>>> > +/* {{{ proto boolean tidyNode::getParent() >>>> > + Returns the parent node if available or NULL */ >>>> > +TIDY_NODE_METHOD(getParent) >>>> > +{ >>>> > + TidyNode parent_node; >>>> > + PHPTidyObj *newobj; >>>> > + TIDY_FETCH_ONLY_OBJECT; >>>> > + >>>> > + parent_node = tidyGetParent(obj->node); >>>> > + if(parent_node) { >>>> > + tidy_instanciate(tidy_ce_node, return_value TSRMLS_CC); >>>> > + newobj = (PHPTidyObj *) >>>> zend_object_store_get_object(return_value TSRMLS_CC); >>>> > + newobj->node = parent_node; >>>> > + newobj->type = is_node; >>>> > + newobj->ptdoc = obj->ptdoc; >>>> > + newobj->ptdoc->ref_count++; >>>> > + tidy_add_default_properties(newobj, is_node TSRMLS_CC); >>>> > + } else { >>>> > + ZVAL_NULL(return_value); >>>> > + } >>>> > +} >>>> > +/* }}} */ >>>> > + >>>> > + >>>> > static void _php_tidy_register_nodetypes(INIT_FUNC_ARGS) >>>> > { >>>> > TIDY_NODE_CONST(ROOT, Root); >>>> > >>>> > -- >>>> > PHP Internals - PHP Runtime Development Mailing List >>>> > To unsubscribe, visit: http://www.php.net/unsub.php >>>> >>>> -- >>>> PHP Internals - PHP Runtime Development Mailing List >>>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >>> >>> >> > > -- Give me your money at @ Donating money may make me happier and friendlier for a limited period! Death to all 4 letter abbreviations starting with P!