Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:2116
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Reply-to:marcus.boerger@post.rwth-aachen.de
Message-ID: <5.1.0.14.2.20030601023239.03084758@pop.t-online.de>
Date: Sun, 01 Jun 2003 02:34:41 +0200
To: David Brown <dave@codewhore.org>
Cc: PHP Developers List <internals@lists.php.net>
In-Reply-To: <20030601000427.GA5775@codewhore.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: [PHP-DEV] Re: CVS commit in ZendEngine2/zend_execute.c
From: marcus.boerger@t-online.de ((Marcus =?iso-8859-1?Q?B=F6rger?=))
References: <20030601000427.GA5775@codewhore.org>

At 02:04 01.06.2003, David Brown wrote:
> > zend_execute.c, 1.468 (sterling)
> > Sat May 31 14:31:28 2003 (5 hours, 35 minutes ago)
> > revert the function call caching patch until a new solution is decided
> > upon.
>
>Hi:
>
>Is this being reverted due to a reported crash? If not, I'm currently
>seeing several with the patch applied (which go away with the recent
>revert). Valgrind says:
>
>  Conditional jump or move depends on uninitialised value(s)
>    at 0x817367D: zend_init_fcall_by_name_handler (zend_execute.c:2565)
>     by 0x816EC54: execute (zend_execute.c:1247)
>     by 0x8173B14: zend_do_fcall_common_helper (zend_execute.c:2654)
>     by 0x8173F6A: zend_do_fcall_by_name_handler (zend_execute.c:2725)
>
>I can supply backtraces and try to derive a test case if this is a new
>crash.  If not, I'm relieved that I wasn't debugging alone - I've had a
>'0 &&' in the reverted if() for the past 12 hours. :)

Yes David,

in ZTS mode it causes much problems, i found them some hours ago. But the main
reason for revert is that the patch was done in the wrong way. Currently we 
are trying
to figure out a new way since the performance boost is very good.

regards
marcus