Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:20204 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 20032 invoked by uid 1010); 20 Nov 2005 20:38:23 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 20016 invoked from network); 20 Nov 2005 20:38:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Nov 2005 20:38:23 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:60948] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 97/7C-11378-DBED0834 for ; Sun, 20 Nov 2005 15:38:22 -0500 Received: from [192.168.1.3] (dslb-084-063-051-138.pools.arcor-ip.net [84.63.51.138]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 31BBE610282; Sun, 20 Nov 2005 21:43:57 +0100 (CET) Date: Sun, 20 Nov 2005 21:38:25 +0100 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <1324198662.20051120213825@marcus-boerger.de> To: Stefan Esser Cc: PHP internals In-Reply-To: <4380982D.7000303@hardened-php.net> References: <4380982D.7000303@hardened-php.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Hash Function change between PHP4 and PHP5 From: helly@php.net (Marcus Boerger) Hello Stefan, as said in private already. This pretty much looiooks like a take over problem. And as a sidenote, loop unwinding with string algorithmns should take care of byte alignment. Both said the code is damn wrong. marcus Sunday, November 20, 2005, 4:37:17 PM, you wrote: > Hello, > I just realised, that between PHP4 and PHP5 we changed the hash function > used within zend_hash.h from DJBX33X to DJBX33A. The diff is here => > http://cvs.php.net/diff.php/ZendEngine2/zend_hash.h?ws=0&r1=1.57&r2=1.58&ty=u > Does anyone remember the exact reason for that? Or was the change done > by accident when the loops were unrolled? I have no idea if there is a > big difference for our hashing needs, but I am just curious if we > changed it because of benchmarks... > Stefan Esser > -- > -------------------------------------------------------------------------- > Stefan Esser sesser@php.net > Hardened-PHP Project http://www.hardened-php.net/ > GPG-Key gpg --keyserver pgp.mit.edu --recv-key 0x15ABDA78 > Key fingerprint 7806 58C8 CFA8 CE4A 1C2C 57DD 4AE1 795E 15AB DA78 > -------------------------------------------------------------------------- Best regards, Marcus