Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:20198 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 8014 invoked by uid 1010); 20 Nov 2005 15:37:24 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 7999 invoked from network); 20 Nov 2005 15:37:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Nov 2005 15:37:24 -0000 X-Host-Fingerprint: 81.169.145.165 natsmtp00.rzone.de Solaris 8 (1) Received: from ([81.169.145.165:45832] helo=natsmtp00.rzone.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id E0/5F-11378-23890834 for ; Sun, 20 Nov 2005 10:37:23 -0500 Received: from [192.168.1.77] (p508775FD.dip.t-dialin.net [80.135.117.253]) by post.webmailer.de (8.13.1/8.13.1) with ESMTP id jAKFbHT8015876 for ; Sun, 20 Nov 2005 16:37:18 +0100 (MET) Message-ID: <4380982D.7000303@hardened-php.net> Date: Sun, 20 Nov 2005 16:37:17 +0100 User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: PHP internals X-Enigmail-Version: 0.93.0.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Hash Function change between PHP4 and PHP5 From: sesser@hardened-php.net (Stefan Esser) Hello, I just realised, that between PHP4 and PHP5 we changed the hash function used within zend_hash.h from DJBX33X to DJBX33A. The diff is here => http://cvs.php.net/diff.php/ZendEngine2/zend_hash.h?ws=0&r1=1.57&r2=1.58&ty=u Does anyone remember the exact reason for that? Or was the change done by accident when the loops were unrolled? I have no idea if there is a big difference for our hashing needs, but I am just curious if we changed it because of benchmarks... Stefan Esser -- -------------------------------------------------------------------------- Stefan Esser sesser@php.net Hardened-PHP Project http://www.hardened-php.net/ GPG-Key gpg --keyserver pgp.mit.edu --recv-key 0x15ABDA78 Key fingerprint 7806 58C8 CFA8 CE4A 1C2C 57DD 4AE1 795E 15AB DA78 --------------------------------------------------------------------------