Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:20125 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37939 invoked by uid 1010); 18 Nov 2005 03:11:55 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 37924 invoked from network); 18 Nov 2005 03:11:55 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 18 Nov 2005 03:11:55 -0000 X-Host-Fingerprint: 216.117.147.250 unknown Linux 2.4/2.6 Received: from ([216.117.147.250:39917] helo=ctindustries.net) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 52/A3-07637-A764D734 for ; Thu, 17 Nov 2005 22:11:54 -0500 Received: from [127.0.0.1] (dsta-aa203.pivot.net [66.186.171.203]) (authenticated bits=0) by ctindustries.net (8.12.8/8.12.8) with ESMTP id jAI20c0u029354; Thu, 17 Nov 2005 21:00:41 -0500 Message-ID: <437D481B.90707@ctindustries.net> Date: Thu, 17 Nov 2005 22:18:51 -0500 User-Agent: Thunderbird 1.5 (Windows/20051025) MIME-Version: 1.0 To: Marcus Boerger , "internals@lists.php.net" Content-Type: multipart/mixed; boundary="------------020205070705020809040307" X-Virus-Scanned: ClamAV 0.87/1177/Thu Nov 17 03:35:37 2005 on ctindustries.net X-Virus-Status: Clean Subject: reflection ext From: rrichards@ctindustries.net (Rob Richards) --------------020205070705020809040307 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Marcus, are you going to be using any module globals in the extension? I had to remove the code for it to get it to build on windows - patached attached. Though it does build fine if you do define some. Rob --------------020205070705020809040307 Content-Type: text/plain; name="php_reflection.c.diff.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="php_reflection.c.diff.txt" Index: php_reflection.c =================================================================== RCS file: /repository/php-src/ext/reflection/php_reflection.c,v retrieving revision 1.190 diff -u -r1.190 php_reflection.c --- php_reflection.c 17 Nov 2005 22:59:38 -0000 1.190 +++ php_reflection.c 18 Nov 2005 03:14:00 -0000 @@ -50,18 +50,6 @@ PHPAPI zend_class_entry *reflection_property_ptr; PHPAPI zend_class_entry *reflection_extension_ptr; -ZEND_BEGIN_MODULE_GLOBALS(reflection) -ZEND_END_MODULE_GLOBALS(reflection) - -#ifdef ZTS -# define REFLECTION_G(v) \ - TSRMG(reflection_globals_id, zend_reflection_globals*, v) -extern int reflection_globals_id; -#else -# define REFLECTION_G(v) (reflection_globals.v) -extern zend_reflection_globals reflectionglobals; -#endif - #ifdef COMPILE_DL_REFLECTION ZEND_GET_MODULE(reflection) #endif @@ -4184,17 +4172,10 @@ } /* }}} */ -static void reflection_init_globals(zend_reflection_globals *globals) /* {{{ */ -{ - /* Initialize your global struct */ -} /* }}} */ - PHP_MINIT_FUNCTION(reflection) /* {{{ */ { zend_class_entry _reflection_entry; - ZEND_INIT_MODULE_GLOBALS(reflection, reflection_init_globals, NULL); - zend_std_obj_handlers = zend_get_std_object_handlers(); memcpy(&reflection_object_handlers, zend_get_std_object_handlers(), sizeof(zend_object_handlers)); reflection_object_handlers.clone_obj = NULL; --------------020205070705020809040307--