Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:201
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <5.1.0.14.2.20030323225458.0484de58@127.0.0.1>
Date: Sun, 23 Mar 2003 22:55:38 +0200
To: Andrei Zmievski <andrei@gravitonic.com>, stas@zend.com
Cc: PHP Internals <internals@lists.php.net>
In-Reply-To: <20030321110205.GA10429@hyperion.gravitonic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed
Subject: Re: doc comment patch
From: andi@zend.com (Andi Gutmans)
References: <20030321110205.GA10429@hyperion.gravitonic.com>

Hi,

I'm not quite sure. Can you send me a patch which includes the shift/reduce 
conflicts and I'll try and mess around with it? (I'm a bit busy lately so I 
hope I'll find time quickly).

Andi

At 06:02 AM 3/21/2003 -0500, Andrei Zmievski wrote:
>Andi and Stas,
>
>Here is reworked version of doc comment patch. It doesn't store last doc
>comment in the compiler globals anymore, instead it's returned inside
>the T_DOC_COMMENT token. I've also modified a couple of rules in the
>parser to store the doc comment in zend_class_entry and zend_op_array
>for classes and functions respectively. There is one problem, however,
>that I need your help with. I tried adding optional_doc_comment to class
>method declaration but it resulted in a bunch of shift/reduce conflicts.
>I am not a parser expert, so might you tell me to fix it? The patch is
>attached.
>
>-Andrei                                       http://www.gravitonic.com/
>
>"Beware of bugs in the above code; I have only proved it correct,
>  not tried it." -- Donald Knuth