Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:20021
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Date: Tue, 15 Nov 2005 19:35:35 +0200 (EET)
Reply-To: Jani Taskinen <sniper@iki.fi>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
cc: internals@lists.php.net
In-Reply-To: <437A1BD1.9030309@lerdorf.com>
Message-ID: <Pine.LNX.4.61.0511151934080.25831@arfg.argcubovn.sv>
References: <437A0D24.6030701@caedmon.net> <Pine.LNX.4.61.0511151858240.25831@arfg.argcubovn.sv>
	<20051115181307.18c2b27b@localhost.localdomain> <437A1820.8060902@lerdorf.com>
	<Pine.LNX.4.61.0511151925260.25831@arfg.argcubovn.sv> <437A1BD1.9030309@lerdorf.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [PHP-DEV] date() behaviour changed in 5.1?
From: sniper@iki.fi (Jani Taskinen)

On Tue, 15 Nov 2005, Rasmus Lerdorf wrote:

>
> Jani Taskinen wrote:
>> On Tue, 15 Nov 2005, Rasmus Lerdorf wrote:
>> 
>>> 
>>> Pierre wrote:
>>>> On Tue, 15 Nov 2005 18:59:32 +0200 (EET)
>>>> sniper@iki.fi (Jani Taskinen) wrote:
>>>> 
>>>>>      If you pass bad data to a function, it should not warn you?
>>>>>      I'd rather have it as a FATAL error. :)
>>>>> 
>>>>>      Nothing to fix here, move along. (and fix your code..)
>>>> 
>>>> PHP is losely typed, I see nothing wrong to pass an integer as string
>>>> there (for example, imagecreate("100", "100"); works).
>>> 
>>> The question isn't what to do with "100","100" but what to do with 
>>> "100abc","100abc".  Should that still work?  The old zend_get_parameters() 
>>> following by a convert_to_long() says Yes.  The newer 
>>> zend_parse_parameters() says no.
>> 
>>     With new version it's possible to catch such typos, with old one they'd
>>     just be silently ignored and perhaps could cause very hard to find bugs 
>> in your code..
>
> I suppose, but I still find it weird that:
>
>  date("h", (int)$foo);
>
> and
>
>  date("h", $foo);
>
> will behave differently when $foo isn't a clean numeric string.  And when we 
> move 100% to zend_parse_parameters() in PHP 6 there will be many more 
> functions changing their behaviour due to this.

     I bet this isn't only thing that's changing. But you really can't get an
     omelette without breaking some eggs, can you? :)

     --Jani