Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:20020
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <437A1BD1.9030309@lerdorf.com>
Date: Tue, 15 Nov 2005 09:33:05 -0800
User-Agent: Thunderbird 1.5 (Macintosh/20051025)
MIME-Version: 1.0
To: Jani Taskinen <sniper@iki.fi>
CC: internals@lists.php.net
References: <437A0D24.6030701@caedmon.net> <Pine.LNX.4.61.0511151858240.25831@arfg.argcubovn.sv> <20051115181307.18c2b27b@localhost.localdomain> <437A1820.8060902@lerdorf.com> <Pine.LNX.4.61.0511151925260.25831@arfg.argcubovn.sv>
In-Reply-To: <Pine.LNX.4.61.0511151925260.25831@arfg.argcubovn.sv>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] date() behaviour changed in 5.1?
From: rasmus@lerdorf.com (Rasmus Lerdorf)

Jani Taskinen wrote:
> On Tue, 15 Nov 2005, Rasmus Lerdorf wrote:
> 
>>
>> Pierre wrote:
>>> On Tue, 15 Nov 2005 18:59:32 +0200 (EET)
>>> sniper@iki.fi (Jani Taskinen) wrote:
>>>
>>>>      If you pass bad data to a function, it should not warn you?
>>>>      I'd rather have it as a FATAL error. :)
>>>>
>>>>      Nothing to fix here, move along. (and fix your code..)
>>>
>>> PHP is losely typed, I see nothing wrong to pass an integer as string
>>> there (for example, imagecreate("100", "100"); works).
>>
>> The question isn't what to do with "100","100" but what to do with 
>> "100abc","100abc".  Should that still work?  The old 
>> zend_get_parameters() following by a convert_to_long() says Yes.  The 
>> newer zend_parse_parameters() says no.
> 
>     With new version it's possible to catch such typos, with old one they'd
>     just be silently ignored and perhaps could cause very hard to find 
> bugs in your code..

I suppose, but I still find it weird that:

   date("h", (int)$foo);

and

   date("h", $foo);

will behave differently when $foo isn't a clean numeric string.  And 
when we move 100% to zend_parse_parameters() in PHP 6 there will be many 
more functions changing their behaviour due to this.

-Rasmus