Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:20004
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <437A0D24.6030701@caedmon.net>
Date: Tue, 15 Nov 2005 11:30:28 -0500
User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716)
MIME-Version: 1.0
To: internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: date() behaviour changed in 5.1?
From: sean@caedmon.net (Sean Coates)

I discussed this with Rasmus and Derick, yesterday, but I don't think we
came to a conclusion..

Is this a bug, or intended behaviour?

sean@iconoclast:~$ /opt/src/php-5.0.4/sapi/cli/php -r 'echo date("r",
"1132003418 ") ."\n";'
Mon, 14 Nov 2005 16:23:38 -0500
sean@iconoclast:~$ /opt/src/php5-200511131530/sapi/cli/php -r 'echo
date("r", "1132003418 ") ."\n";'

Warning: date() expects parameter 2 to be long, string given in Command
line code on line 1

sean@iconoclast:~$

The conclusion SEEMED to be that it's a bug in the parameter parsing API
(as date() now uses the new API).

I think that the 2nd param should automatically be cast to an int. Yes,
I realize that the documentation says it should be an int, and I'm ok
with that (the extraneous whitespace is my fault). I think it should be
mentioned in the release docs if it won't be fixed, though.

Also, a warning is pretty harsh. A E_NOTICE is more representative of
what's happening. Also, in the E_WARNING scenario above, date() no
longer returns the expected result (based on <=5.0 code).

So: is this a bug? If so, I can send a report -- I just didn't want it
to get bogussed without discussion.

If not -- I really think this should be fixed before 5.1.. I realize
it's very late in the game, though.

Opinions?

S