Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19930 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 47763 invoked by uid 1010); 9 Nov 2005 05:05:31 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 47748 invoked from network); 9 Nov 2005 05:05:31 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Nov 2005 05:05:31 -0000 X-Host-Fingerprint: 195.197.172.115 gw01.mail.saunalahti.fi Linux 2.4/2.6 Received: from ([195.197.172.115:34637] helo=gw01.mail.saunalahti.fi) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 7A/17-05064-99381734 for ; Wed, 09 Nov 2005 00:05:29 -0500 Received: from nest.netphobia.fi (YZDCXXXI.dsl.saunalahti.fi [85.76.35.232]) by gw01.mail.saunalahti.fi (Postfix) with ESMTP id AEDF1FDFF0; Wed, 9 Nov 2005 07:05:23 +0200 (EET) Received: from nest.netphobia.fi (nest.netphobia.fi [127.0.0.1]) by nest.netphobia.fi (8.13.1/8.13.1) with ESMTP id jA955Nmf007636; Wed, 9 Nov 2005 07:05:23 +0200 Received: from localhost (jani@localhost) by nest.netphobia.fi (8.13.1/8.13.1/Submit) with ESMTP id jA955N72007633; Wed, 9 Nov 2005 07:05:23 +0200 X-Authentication-Warning: nest.netphobia.fi: jani owned process doing -bs Date: Wed, 9 Nov 2005 07:05:23 +0200 (EET) Reply-To: Jani Taskinen To: Pierangelo Masarati cc: venaas@php.net, internals@lists.php.net In-Reply-To: <1131492177.3327.25.camel@ando> Message-ID: References: <1131485315.3327.15.camel@ando> <1131492177.3327.25.camel@ando> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [PHP-DEV] LDAP controls in response From: sniper@iki.fi (Jani Taskinen) The "control-patch" looks okay. But the "warning-fix-patch" really doesn't. You're actually changing some functions behaviour with some of those changes. Maybe you didn't notice but there's ldap_get_values() and ldap_get_values_len() separately. And there's ldap_bind() and ldap_sasl_bind(), --Jani On Wed, 9 Nov 2005, Pierangelo Masarati wrote: > On Wed, 2005-11-09 at 00:37 +0200, Jani Taskinen wrote: >> I quickly glanced through your patch and if you don't mind, >> can you please separate the warning-fixes and functionality patch? >> (one patch for fixes, one for adding new stuff :) >> >> It's a bit too much to try and see what was added and what is supposed >> to silence some warning. > > Sure. > > I quickly separated them by editing the patch, so you'll likely get some > fuzz message because of wrong line count. They should apply in any > order, though, because there was no code overlapping. I successfully > did warnings, controls. > > Sincerely, p. > > > > Ing. Pierangelo Masarati > Responsabile Open Solution > > SysNet s.n.c. > Via Dossi, 8 - 27100 Pavia - ITALIA > http://www.sys-net.it > ------------------------------------------ > Office: +39.02.23998309 > Mobile: +39.333.4963172 > Email: pierangelo.masarati@sys-net.it > ------------------------------------------ > >