Newsgroups: php.internals,php.internals
Path: news.php.net
Xref: news.php.net php.internals:19904 php.internals:19905
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Mime-Version: 1.0 (Apple Message framework v746.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-ID: <81D9588B-8984-432C-91CB-9ECE28F573F0@thieso.net>
Cc: Thies Arntzen <thies@thieso.net>
Content-Transfer-Encoding: 7bit
Date: Fri, 4 Nov 2005 09:35:08 +0100
To: internals@lists.php.net
mewhen anyhow, but not now).  so, in one sentence: as we don't protect against recustion elsewhere, can we please remove this unneded roadblock?  opinions? -thies  
From: thies@thieso.net ("Thies C. Arntzen")

hey,

in zend_object_handlers.c function zend_std_read_property we protect  
against calling the __get function of an object if we're already in a  
__get() function. (look for zobj->in_get) in that function.

i don't think we should be doing this.

simplyfied example:
<?php
class test {
     function __get($offset) {
         echo "__get($offset)\n";
         switch ($offset) {
             case 'name': return "name";
             case 'length': return strlen($this->name);
         }
     }
}

$a = new test;
var_dump($a->length);
?>

outputs:
__get(length)
int(0)

but should say:
__get(length)
__get(name)
int(4)

i think recursive gets are highly useful and should be allowed. if we  
really want to protect against recursion (here) we have two real  
options: -a- protect against __get(ing) the same property more than  
once in the same call-chain (mucho work), or -b- (preferred) have  
some global infinite recursion protection in the engine (needs to be  
done somewhen anyhow, but not now).

so, in one sentence: as we don't protect against recustion elsewhere,  
can we please remove this unneded roadblock?

opinions?
-thies