Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:19897
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
To: Markus Fischer <markus@fischer.name>
Cc: Matteo Beccati <php@beccati.com>, internals@lists.php.net
In-Reply-To: <4369B150.2000205@fischer.name>
References: <4369513B.1020502@beccati.com>  <4369B150.2000205@fischer.name>
Content-Type: text/plain
Organization: Album Limited
Date: Thu, 03 Nov 2005 19:48:35 +1300
Message-ID: <1131000515.18534.11.camel@jasper.local>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] What about a PHP 4.4.1pl1?
From: jasper@album.co.nz (Jasper Bryant-Greene)

On Thu, 2005-11-03 at 07:42 +0100, Markus Fischer wrote:
> Matteo Beccati wrote:
> > I newly subscribed to this ML after some time I didn't follow it, so I 
> > beg pardon if I'm posting a question that was already discussed.
> > 
> > As you know, a few days ago PHP 4.4.1 was released. As current admin of 
> > a widely used PHP project called phpAdsNew, I discovered just today that 
> > there are compatibility problems with the latest PHP4 release. One of 
> > our users preceded me and opened a bug report, which led to a prompt fix 
> > by Ilia:
> > 
> > http://bugs.php.net/bug.php?id=35067
> > 
> > ( and its duplicate: http://bugs.php.net/bug.php?id=35070 )
> 
> The problem is also that the ChangeLog has no mention of this change of 
> behaviour because it seems this change was done without having a bug to 
> fix (at least not a bug in the database).
> 
> This change was first made in HEAD ( 
> http://cvs.php.net/diff.php/php-src/ext/standard/basic_functions.c?r1=1.732&r2=1.733&ty=u 
> ) and then merged to all branches. But it doesn't reference a bug and 
> doesn't describe what it tries to fix (" Make key() and current() take 
> argument by value." doesn't explain much).

I haven't been following this thread, but I seem to remember discussion
on php-general at some point about the fact that key() and current()
took their argument by reference without any actual need to.

I think there was a post by Rasmus that said this behaviour would change
in the near future, which I assume is the change you quote, but without
searching the archives I can't be more specific.

-- 
Jasper Bryant-Greene
General Manager
Album Limited

e: jasper@album.co.nz
w: http://www.album.co.nz/
b: http://jbg.name/
p: 0800 4 ALBUM (0800 425 286) or +64 21 232 3303
a: PO Box 579, Christchurch 8015, New Zealand