Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19710 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 41225 invoked by uid 1010); 24 Oct 2005 22:45:25 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 41208 invoked from network); 24 Oct 2005 22:45:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Oct 2005 22:45:25 -0000 X-Host-Fingerprint: 80.74.107.235 mail.zend.com Linux 2.5 (sometimes 2.4) (4) Received: from ([80.74.107.235:37015] helo=mail.zend.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 37/7A-22886-3046D534 for ; Mon, 24 Oct 2005 18:45:24 -0400 Received: (qmail 15859 invoked from network); 24 Oct 2005 22:45:19 -0000 Received: from internal.zend.office (HELO ?127.0.0.1?) (10.1.1.1) by internal.zend.office with SMTP; 24 Oct 2005 22:45:19 -0000 Message-ID: <435D6401.6070003@zend.com> Date: Tue, 25 Oct 2005 02:45:21 +0400 User-Agent: Thunderbird 1.4.1 (X11/20051006) MIME-Version: 1.0 To: Marcus Boerger CC: internals@lists.php.net References: <425333877.20051025002259@marcus-boerger.de> In-Reply-To: <425333877.20051025002259@marcus-boerger.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] foreach with null From: antony@zend.com (Antony Dovgal) I'd say silently ignoring it and moving along is fine here. Only if the var IS_NULL, but this is the case. So I'm +1. On 25.10.2005 02:22, Marcus Boerger wrote: > Hello internals, > > i would like to change foreach a tiny bit. Actually i don't like the > warning when using foreach with null. > > marcus@zaphod /usr/src/php-cvs $ php -r '$n=NULL; foreach($n as $v);' > make: `sapi/cli/php' is up to date. > > Warning: Invalid argument supplied for foreach() in Command line code on line 1 > marcus@zaphod /usr/src/php-cvs $ php -r 'foreach(NULL as $v);' > make: `sapi/cli/php' is up to date. > > Warning: Invalid argument supplied for foreach() in Command line code on line 1 > > The way we use NULL in PHP should result in no warning here. The patch for > this can be found here: > http://php.net/~helly/php/ext/ze2/ze2-foreach-null-20051025.diff.txt > It was made with head but applies to 5.1 as well. > > Any opinions? -- Wbr, Antony Dovgal