Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19643 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59013 invoked by uid 1010); 16 Oct 2005 19:19:16 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 58997 invoked from network); 16 Oct 2005 19:19:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 16 Oct 2005 19:19:16 -0000 X-Host-Fingerprint: 212.55.154.23 relay3.ptmail.sapo.pt Linux 2.4/2.6 Received: from ([212.55.154.23:55781] helo=sapo.pt) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 84/28-22302-3B7A2534 for ; Sun, 16 Oct 2005 15:19:16 -0400 Received: (qmail 28466 invoked from network); 16 Oct 2005 19:19:11 -0000 Received: from unknown (HELO sapo.pt) (10.134.35.154) by relay3 with SMTP; 16 Oct 2005 19:19:11 -0000 Received: (qmail 7366 invoked from network); 16 Oct 2005 19:19:11 -0000 X-AntiVirus: PTMail-AV 0.3.87 X-Virus-Status: Clean (0.17121 seconds) Received: from unknown (HELO pc07653) (nunoplopes@sapo.pt@[82.154.18.110]) (envelope-sender ) by mta4 (qmail-ldap-1.03) with SMTP for ; 16 Oct 2005 19:19:11 -0000 Message-ID: <002101c5d286$78ccde70$0100a8c0@pc07653> To: "Derick Rethans" Cc: "PHPdev" References: <001501c5d10d$fb343590$0100a8c0@pc07653> Date: Sun, 16 Oct 2005 20:19:03 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.2670 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.2670 Subject: Re: [PHP-DEV] Re: report of date functions on windows From: nlopess@php.net ("Nuno Lopes") >> 1) timelib_tz_lookup_table defines the gmtoffset as an int, but in the >> fallback table there are some decimals numbers. So, either remove those >> entries or change the struct to hold a float. This also applies to the >> timelib_timezone_id_from_abbr() function, which receives a long, instead >> of a >> float. >> > I committed a slightly modified patch (you should not use any of the > US/* mappings f.e.). Thanks. > > regards, > Derick OK, thanks! And have you decided anything about 1)? May I help in anything? (personally I think that using a float there is a bit overkill in memory usage..) Nuno