Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:19621
Return-Path: <derick@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 60202 invoked by uid 1010); 15 Oct 2005 18:20:35 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 60187 invoked from network); 15 Oct 2005 18:20:35 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 15 Oct 2005 18:20:35 -0000
X-Host-Fingerprint: 82.94.239.5 jdi.jdi-ict.nl Linux 2.5 (sometimes 2.4) (4)
Received: from ([82.94.239.5:55750] helo=jdi.jdi-ict.nl)
	by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP
	id 96/3C-22302-07841534 for <internals@lists.php.net>; Sat, 15 Oct 2005 14:20:33 -0400
Received: from localhost (localhost [127.0.0.1])
	by jdi.jdi-ict.nl (8.12.11/8.12.11) with ESMTP id j9FIKUHp012595;
	Sat, 15 Oct 2005 20:20:30 +0200
Received: from localhost (localhost [127.0.0.1])
	by jdi.jdi-ict.nl (8.12.11/8.12.11) with ESMTP id j9FIKSQZ012589;
	Sat, 15 Oct 2005 20:20:29 +0200
Date: Sat, 15 Oct 2005 20:20:26 +0200 (CEST)
X-X-Sender: derick@localhost
To: Nuno Lopes <nlopess@php.net>
cc: PHPdev <internals@lists.php.net>
In-Reply-To: <001501c5d10d$fb343590$0100a8c0@pc07653>
Message-ID: <Pine.LNX.4.62.0510152019520.2961@localhost>
References: <001501c5d10d$fb343590$0100a8c0@pc07653>
X-Face: "L'&?Ah3MYF@FB4hU'XhNhLB]222(Lbr2Y@F:GE[OO;"F5p>qtFBl|yVVA&D{A(g3[C}mG:199P+5C'v.M/u@Z\![0b:Mv.[l6[uWl'
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Virus-Scanned: by amavisd-new at jdi-ict.nl
Subject: Re: report of date functions on windows
From: derick@php.net (Derick Rethans)

On Fri, 14 Oct 2005, Nuno Lopes wrote:

> Hi,
> 
> In the last hours I've been debugging and testing the new implementation of
> the date related functions on windows.
> I've found some little problems:
> 
> 1) timelib_tz_lookup_table defines the gmtoffset as an int, but in the
> fallback table there are some decimals numbers. So, either remove those
> entries or change the struct to hold a float. This also applies to the
> timelib_timezone_id_from_abbr() function, which receives a long, instead of a
> float.
> 
> 2) in the guess_timezone() function, the offset maths are being truncated. the
> explicit cast to float doesn't help either, because it happens before reaching
> there.
> 
> 3) the fallback table isn't complete (and had an error). I've added a couple
> more tzs.
> 
> 4) I've fixed the problem I've reported earlier with timezones that don't have
> DST settings (or when the user disables DST in control panel).
> 
> 
> A patch to fix 2, 3 and 4: http://mega.ist.utl.pt/~ncpl/php_win_date2.txt

I committed a slightly modified patch (you should not use any of the 
US/* mappings f.e.). Thanks.

regards,
Derick

-- 
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org