Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:19619
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <001501c5d10d$fb343590$0100a8c0@pc07653>
To: <derick@php.net>
Cc: "PHPdev" <internals@lists.php.net>
Date: Fri, 14 Oct 2005 23:24:02 +0100
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="Windows-1252";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: report of date functions on windows
From: nlopess@php.net ("Nuno Lopes")

Hi,

In the last hours I've been debugging and testing the new implementation of 
the date related functions on windows.
I've found some little problems:

1) timelib_tz_lookup_table defines the gmtoffset as an int, but in the 
fallback table there are some decimals numbers. So, either remove those 
entries or change the struct to hold a float. This also applies to the 
timelib_timezone_id_from_abbr() function, which receives a long, instead of 
a float.

2) in the guess_timezone() function, the offset maths are being truncated. 
the explicit cast to float doesn't help either, because it happens before 
reaching there.

3) the fallback table isn't complete (and had an error). I've added a couple 
more tzs.

4) I've fixed the problem I've reported earlier with timezones that don't 
have DST settings (or when the user disables DST in control panel).


A patch to fix 2, 3 and 4: http://mega.ist.utl.pt/~ncpl/php_win_date2.txt


Apart of these little issues, the new code is working perfectly!

Nuno