Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19475 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33288 invoked by uid 1010); 7 Oct 2005 13:34:08 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 33273 invoked from network); 7 Oct 2005 13:34:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Oct 2005 13:34:08 -0000 X-Host-Fingerprint: 82.94.239.5 jdi.jdi-ict.nl Linux 2.5 (sometimes 2.4) (4) Received: from ([82.94.239.5:57605] helo=jdi.jdi-ict.nl) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id BA/9C-54476-D4976434 for ; Fri, 07 Oct 2005 09:34:06 -0400 Received: from localhost (localhost [127.0.0.1]) by jdi.jdi-ict.nl (8.12.11/8.12.11) with ESMTP id j97DXxHR008429; Fri, 7 Oct 2005 15:33:59 +0200 Received: from localhost (localhost [127.0.0.1]) by jdi.jdi-ict.nl (8.12.11/8.12.11) with ESMTP id j97DXvbd008423; Fri, 7 Oct 2005 15:33:58 +0200 Date: Fri, 7 Oct 2005 15:33:57 +0200 (CEST) X-X-Sender: derick@localhost To: Kamesh Jayachandran cc: internals@lists.php.net In-Reply-To: <1128691492.11773.244641910@webmail.messagingengine.com> Message-ID: References: <1128691492.11773.244641910@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdi-ict.nl Subject: Re: change of variable name from tzname to formal_tzname From: derick@php.net (Derick Rethans) Hello, On Fri, 7 Oct 2005, Kamesh Jayachandran wrote: > From Yesterday(06/10/2005) onwards NetWare php-5.1 autotests were > failing because of a segfault from tests/lang/023.phpt which makes one > mktime call. > When delved for the cause it seems that In NetWare LibC SDK's time.h > tzname is expanded to ___tzname() this cause the C preprocessor to > change the tzname to vague ___tzname function call in > php_date_parse_tzfile(). > Changing the variable name tzname to formal_tzname or anything more > pleasing in php_date_parse_tzfile should fix it. > > http://puggy.symonds.net/~kameshj/php_date.c.patch > > Can you check in this? Yes, I just committed it. regards, Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org