Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19473 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26477 invoked by uid 1010); 7 Oct 2005 13:24:57 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 26461 invoked from network); 7 Oct 2005 13:24:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Oct 2005 13:24:57 -0000 X-Host-Fingerprint: 66.111.4.27 out3.smtp.messagingengine.com Received: from ([66.111.4.27:46860] helo=out3.smtp.messagingengine.com) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 67/BB-54476-82776434 for ; Fri, 07 Oct 2005 09:24:56 -0400 Received: from frontend1.internal (mysql-sessions.internal [10.202.2.149]) by frontend1.messagingengine.com (Postfix) with ESMTP id 2B3A3CD118E; Fri, 7 Oct 2005 09:24:52 -0400 (EDT) Received: from web1.messagingengine.com ([10.202.2.210]) by frontend1.internal (MEProxy); Fri, 07 Oct 2005 09:24:52 -0400 Received: by web1.messagingengine.com (Postfix, from userid 99) id 911301BD1; Fri, 7 Oct 2005 09:24:52 -0400 (EDT) Message-ID: <1128691492.11773.244641910@webmail.messagingengine.com> X-Sasl-Enc: 83dq3d0KBdBqHrd5qOfj49QKI7WdhPNREd4RX5RawNEw 1128691492 To: derick@php.net Cc: internals@lists.php.net Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-Mailer: MIME::Lite 1.5 (F2.73; T1.15; A1.64; B3.05; Q3.03) Date: Fri, 07 Oct 2005 18:54:52 +0530 Subject: change of variable name from tzname to formal_tzname From: kameshj@fastmail.fm ("Kamesh Jayachandran") Hi Derick, From Yesterday(06/10/2005) onwards NetWare php-5.1 autotests were failing because of a segfault from tests/lang/023.phpt which makes one mktime call. When delved for the cause it seems that In NetWare LibC SDK's time.h tzname is expanded to ___tzname() this cause the C preprocessor to change the tzname to vague ___tzname function call in php_date_parse_tzfile(). Changing the variable name tzname to formal_tzname or anything more pleasing in php_date_parse_tzfile should fix it. http://puggy.symonds.net/~kameshj/php_date.c.patch Can you check in this? With regards Kamesh Jayachandran --=20 http://www.fastmail.fm - And now for something completely different=85