Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19441 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48945 invoked by uid 1010); 6 Oct 2005 12:35:33 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 48929 invoked from network); 6 Oct 2005 12:35:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Oct 2005 12:35:33 -0000 X-Host-Fingerprint: 192.38.9.232 gw2.emini.dk Linux 2.4/2.6 Received: from ([192.38.9.232:4515] helo=gw2.emini.dk) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 72/73-54476-41A15434 for ; Thu, 06 Oct 2005 08:35:32 -0400 Received: by gw2.emini.dk (Postfix, from userid 504) id 82450879B5; Thu, 6 Oct 2005 14:35:28 +0200 (CEST) Received: from [10.0.0.18] (palestine.intra.emini.dk [10.0.0.18]) by gw2.emini.dk (Postfix) with ESMTP id 7F3DE8798A; Thu, 6 Oct 2005 14:35:27 +0200 (CEST) Message-ID: <43451A0F.9070206@emini.dk> Date: Thu, 06 Oct 2005 14:35:27 +0200 Organization: Emini A/S User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Edin Kadribasic Cc: Jani Taskinen , Derick Rethans , Internals References: <4343AEE2.1030706@emini.dk> In-Reply-To: <4343AEE2.1030706@emini.dk> X-Enigmail-Version: 0.92.0.0 OpenPGP: id=157D0FA8 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on gw2.emini.dk X-Spam-Detected: no X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Level: Subject: Re: [PHP-DEV] Build breakage From: edink@emini.dk (Edin Kadribasic) Edin Kadribasic wrote: > Hi Jani, > > Your commit r 1.16 to ext/date/lib/timelib_structs.h broke the build on > Windows platform. > > -#include "timelib_config.h" > +#include > > Why was this change neccessary and if it's not really, would you please > revert it? After strugling to get an anwer for this one it appears that the problem is that Derick wants to maintain timelib as an independet 3rd party lib that is also part of PHP core which means that in order for PHP to build we need to add "timelib" to the global CFLAGS (or at least to the flags of any extension what wants to use it). A mere include "ext/date/php_date.h" wouldn't cut it. Does anyone find this less than optimal? Edin