Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:1925 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 38451 invoked from network); 23 May 2003 12:10:03 -0000 Received: from unknown (HELO mail.zend.com) (192.117.235.230) by pb1.pair.com with SMTP; 23 May 2003 12:10:03 -0000 Received: (qmail 29904 invoked from network); 23 May 2003 12:09:52 -0000 Received: from localhost (HELO andi-laptop.zend.com) (127.0.0.1) by localhost with SMTP; 23 May 2003 12:09:52 -0000 Message-ID: <5.1.0.14.2.20030523150908.06c5d1a8@127.0.0.1> X-Sender: andi@127.0.0.1 X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Fri, 23 May 2003 15:10:03 +0300 To: Sterling Hughes ,internals@lists.php.net Cc: Zeev Suraski In-Reply-To: <5.1.0.14.2.20030522215749.033e4ec0@127.0.0.1> References: <1053622345.28527.44.camel@hasele> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Subject: Re: [PHP-DEV] Re: HANDLE_NUMERIC() From: andi@zend.com (Andi Gutmans) Sterling, I discussed your patch with Zeev. He convinced me that the chance of other PHP extensions taking advantage of HANDLE_NUMERIC is slim and that if this exists, we'll find it by the time we release PHP 5. So I think you should commit it. Andi At 09:58 PM 5/22/2003 +0300, Andi Gutmans wrote: >At 12:52 PM 5/22/2003 -0400, Sterling Hughes wrote: >>Hi, >> >>I've attached a small patch which removes HANDLE_NUMERIC() from >>zend_hash.c, and moves it instead to the necessary places in >>zend_execute.c, in the form of a zend_is_numeric_key() function defined >>in zend_operators.c >> >>Anyhow, I'm getting a really nice performance increase. Although it >>depends on the usage, it certainly makes pretty much everything zippier >>(and dare I say sexier. :) > >I'm not sure you can be certain that other places in PHP don't use the >feature of HANDLE_NUMERIC. >Seems to be quite a dangerous patch to me even if you solved it for the >symbol table. > >Andi > > >-- >PHP Internals - PHP Runtime Development Mailing List >To unsubscribe, visit: http://www.php.net/unsub.php