Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19175 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 91034 invoked by uid 1010); 26 Sep 2005 20:25:22 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 91019 invoked from network); 26 Sep 2005 20:25:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Sep 2005 20:25:22 -0000 X-Host-Fingerprint: 81.169.182.136 ajaxatwork.net Linux 2.4/2.6 Received: from ([81.169.182.136:34999] helo=strato.aixcept.de) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id E4/BE-24510-13958334 for ; Mon, 26 Sep 2005 16:25:22 -0400 Received: from [192.168.1.3] (dsl-082-083-224-150.arcor-ip.net [82.83.224.150]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by strato.aixcept.de (Postfix) with ESMTP id 61F3F35C37F; Mon, 26 Sep 2005 22:25:22 +0200 (CEST) Date: Mon, 26 Sep 2005 22:25:21 +0200 Reply-To: Marcus Boerger X-Priority: 3 (Normal) Message-ID: <492068408.20050926222521@marcus-boerger.de> To: Dmitry Stogov Cc: internals@lists.php.net In-Reply-To: <000501c5c2cb$e11449c0$e902a8c0@thinkpad> References: <1728334199.20050925143657@marcus-boerger.de> <000501c5c2cb$e11449c0$e902a8c0@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] [PATCH] __toString() From: helly@php.net (Marcus Boerger) Hello Dmitry, looks good Monday, September 26, 2005, 8:55:30 PM, you wrote: > Hi Marcus, > This is improved version of your patch. > It breaks only two tests those must be changed. (instead of > 10 those > shouldn't) > Please review. > Thanks. Dmitry. >> -----Original Message----- >> From: Marcus Boerger [mailto:helly@php.net] >> Sent: Sunday, September 25, 2005 4:37 PM >> To: internals >> Subject: [PHP-DEV] [PATCH] __toString() >> >> >> Hello internals, >> >> the patch implements __toString to have obejcts be >> automatically converted to strings anywhere a string is >> requested. We have talked a lot about this in the past and >> during OSCON Andi agreed again on it and said that the HEAD >> version of the engine should be ready for it now. Futher more >> we have enough time to fix any outstanding engine issues >> regarding this. >> >> http://php.net/~helly/php/ext/ze2/ze2-tostring-20050925.diff.txt >> >> If nobody objects with a real technical issue i'll commit >> the patch early in the week. >> >> The patch is a little big longer because it ensures that >> __toString gets treated and especially gets cached just like >> any other magic function is.