Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:19172
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
	s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=Luf2mllxRtDogp400B4Clpxb2zxZ5eAHlb6MBfh2kgHbYvOkaMzCXQbqifmt2cSEuWNNJHxe12anRj8aWpcYbK6v5CDxuTcQcTerF8Xs9MV+18FOeQ1tOyju34h9g+or0fLLLfk8pZW8KLiqzW2UkaoEQ/6ZNYbk0s92PH54DOI=
Message-ID: <4e89b4260509260822f0ac52d@mail.gmail.com>
Date: Mon, 26 Sep 2005 11:22:09 -0400
Reply-To: Wez Furlong <kingwez@gmail.com>
To: Michael Wallner <mike@php.net>
Cc: internals@lists.php.net
In-Reply-To: <DB.BC.24510.97F08334@pb1.pair.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <79.1A.24510.546D2334@pb1.pair.com>
	<91.71.24510.E9A93334@pb1.pair.com>
	<003501c5c064$4782bc60$5c8be5a9@ohr.berkeley.edu>
	<35.D0.24510.B52F7334@pb1.pair.com>
	<001001c5c2aa$f73a7740$6c051fac@lighthammer>
	<DB.BC.24510.97F08334@pb1.pair.com>
Subject: Re: [PHP-DEV] Re: [PATCH] imap_savebody()
From: kingwez@gmail.com (Wez Furlong)

I'd recommend adopting Sara's suggestion; those memset()s you have
there shouldn't be needed:

char buf[GETS_FETCH_SIZE];

while (ret > 0) {
   if (!f(stream, sizeof(buf), buf))
       break;
   php_stream_write_string(IMAPG(gets_stream), buf);
}
return NULL;

--Wez.

On 9/26/05, Michael Wallner <mike@php.net> wrote:
> Hi Sara Golemon, you wrote:
>
> > Here's how I'd write this block, it assumed that f returns the number o=
f
> > bytes actually read, but according to the proto for readfn_t it *should=
*
> > do that.
>
> Well, unfortunately not.  It seems that net_get_buffer() in mail.c is
> used as standard readfn_t which only returns NIL/T i.e. 0/1.
>
> But the patch's implementation is by no means mandatory, it's just
> about getting the data out with enabled memory_limit, so I actually
> wouldn't mind if it would get implemented in a totally different way ;)
>
> Regards,
> --
> Michael - < mike(@)php.net >
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>