Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19171 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35892 invoked by uid 1010); 26 Sep 2005 15:10:50 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 35877 invoked from network); 26 Sep 2005 15:10:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Sep 2005 15:10:50 -0000 X-Host-Fingerprint: 212.183.37.172 M2446P012.adsl.highway.telekom.at Received: from ([212.183.37.172:22364] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id DB/BC-24510-97F08334 for ; Mon, 26 Sep 2005 11:10:49 -0400 Message-ID: To: internals@lists.php.net Date: Mon, 26 Sep 2005 17:10:38 +0200 Organization: IWORKS User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.2) Gecko/20040803 [ http://iworks.at ] X-Accept-Language: de-AT, de-DE, de, en, en-GB, en-US MIME-Version: 1.0 References: <79.1A.24510.546D2334@pb1.pair.com> <91.71.24510.E9A93334@pb1.pair.com> <003501c5c064$4782bc60$5c8be5a9@ohr.berkeley.edu> <35.D0.24510.B52F7334@pb1.pair.com> <001001c5c2aa$f73a7740$6c051fac@lighthammer> In-Reply-To: <001001c5c2aa$f73a7740$6c051fac@lighthammer> X-Enigmail-Version: 0.90.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Posted-By: 212.183.37.172 Subject: Re: [PATCH] imap_savebody() From: mike@php.net (Michael Wallner) Hi Sara Golemon, you wrote: > Here's how I'd write this block, it assumed that f returns the number of > bytes actually read, but according to the proto for readfn_t it *should* > do that. Well, unfortunately not. It seems that net_get_buffer() in mail.c is used as standard readfn_t which only returns NIL/T i.e. 0/1. But the patch's implementation is by no means mandatory, it's just about getting the data out with enabled memory_limit, so I actually wouldn't mind if it would get implemented in a totally different way ;) Regards, -- Michael - < mike(@)php.net >