Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:19170
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <001001c5c2aa$f73a7740$6c051fac@lighthammer>
To: "Michael Wallner" <mike@php.net>
Cc: <internals@lists.php.net>
References: <79.1A.24510.546D2334@pb1.pair.com> <91.71.24510.E9A93334@pb1.pair.com> <003501c5c064$4782bc60$5c8be5a9@ohr.berkeley.edu> <35.D0.24510.B52F7334@pb1.pair.com>
Date: Mon, 26 Sep 2005 07:59:58 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] imap_savebody()
From: pollita@php.net ("Sara Golemon")

Looks basicly alright (with a slight disagreement on how the read loop is 
implemented (below).  In general you've got my vote (for what it's worth 
given my lack of experience with libc-client.



unsigned long i, rest = size % GETS_FETCH_SIZE;
char *buf = emalloc(GETS_FETCH_SIZE+1);

	for (i = GETS_FETCH_SIZE; i < size; i += GETS_FETCH_SIZE) {
    memset(buf, 0, GETS_FETCH_SIZE+1);
    f(stream, GETS_FETCH_SIZE, buf);
    php_stream_write_string(IMAPG(gets_stream), buf);
 }
 if (rest) {
    memset(buf, 0, GETS_FETCH_SIZE+1);
    f(stream, rest, buf);
    php_stream_write_string(IMAPG(gets_stream), buf);
 }
efree(buf);
return NULL;



Here's how I'd write this block, it assumed that f returns the number of 
bytes actually read, but according to the proto for readfn_t it *should* do 
that.  Feel free to ignore:

char buf[GETS_FETCH_SIZE];
unsigned long ret = 1;

while (ret > 0) {
    ret = f(stream, GETS_FETCH_SIZE, buf);
    php_stream_write_stringl(IMAPG(gets_stream), buf, ret);
}
return NULL;