Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:19144
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Message-ID: <003501c5c064$4782bc60$5c8be5a9@ohr.berkeley.edu>
Reply-To: "Sara Golemon" <pollita@php.net>
To: "Michael Wallner" <mike@php.net>
Cc: <internals@lists.php.net>
References: <79.1A.24510.546D2334@pb1.pair.com> <91.71.24510.E9A93334@pb1.pair.com>
Date: Fri, 23 Sep 2005 10:28:07 -0700
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH] imap_savebody()
From: pollita@php.net ("Sara Golemon")

> > http://dev.iworks.at/PATCHES/imap_savebody.patch.txt
>
> Thanks a lot for review; the patch has been updated with your suggestions.
> Additionally the whole thing is ifdef'd out in ZTS mode as the c-client
> gets function is a global variable.  I tested the function with a 17M
> message saving to a file as well to an already opened stream.
>
Getting there, but you can make it work for ZTS mode.  Just create a proxy
for the gets function which is always set, then have the proxy do a
TSRMLS_FETCH() and examine an extension global (e.g. IMAPG(gets_mode) or
whatever) to determine whether it's in savebody() and should shuttle to your
new gets function, or if it's not in savebody() and should dispatch to the
"original" method.

Come to that, might as well just make IMAPG(real_gets) as a dynamic
function....  Not that I've looked at ext/imap enough to know what the role
of gets is precisely.

-Sara