Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:19131 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51210 invoked by uid 1010); 22 Sep 2005 16:30:43 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 51191 invoked from network); 22 Sep 2005 16:30:42 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Sep 2005 16:30:42 -0000 X-Host-Fingerprint: 70.85.46.36 unknown Received: from ([70.85.46.36:36250] helo=prohost.org) by pb1.pair.com (ecelerity 2.0 beta r(6323M)) with SMTP id 02/CB-24510-13CD2334 for ; Thu, 22 Sep 2005 12:30:41 -0400 Received: (qmail 9557 invoked from network); 22 Sep 2005 16:30:33 -0000 Received: from cpe000fb56099fd-cm000f9f7d6664.cpe.net.cable.rogers.com (HELO ?192.168.1.101?) (69.196.29.239) by prohost.org with SMTP; 22 Sep 2005 16:30:33 -0000 Message-ID: <4332DC28.1090305@prohost.org> Date: Thu, 22 Sep 2005 12:30:32 -0400 User-Agent: Mozilla Thunderbird 1.0.6 (Windows/20050716) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Sara Golemon CC: Michael Wallner , internals@lists.php.net References: <79.1A.24510.546D2334@pb1.pair.com> <002b01c5bf91$c4d2f550$5c8be5a9@ohr.berkeley.edu> In-Reply-To: <002b01c5bf91$c4d2f550$5c8be5a9@ohr.berkeley.edu> X-Enigmail-Version: 0.92.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: [PATCH] imap_savebody() From: ilia@prohost.org (Ilia Alshanetsky) Sara Golemon wrote: >>#define GETS_FETCH_SIZE 2048000 >> > > That size doesn't seem a bit excessive to you? I thought the whole point of > dumping it to a file was to avoid huge memory chunks. Not to mention the > fact that reserving 2MB of stack space makes me a little twitchy... Indeed, 2 megs of stack space seems a bit much, not to mention completely bypassed PHP's memory limit. I'd recommend allocating 1 megabyte buffer via emalloc(), a bit slower, but much "nicer" IMHO. Ilia