Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:1881
Return-Path: <holger.burbach@gonicus.de>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 8335 invoked from network); 22 May 2003 13:06:54 -0000
Received: from unknown (HELO mail-2.dinet.de) (212.8.6.1)
  by pb1.pair.com with SMTP; 22 May 2003 13:06:54 -0000
Received: from ots-2 (carbon.gonicus.de [212.8.6.6])
	by mail-2.dinet.de (Postfix) with ESMTP
	id 706342CC0AD; Thu, 22 May 2003 15:06:53 +0200 (CEST)
Organization: GONICUS GmbH
To: Derick Rethans <derick@php.net>
Date: Thu, 22 May 2003 15:06:52 +0200
User-Agent: KMail/1.5.1
Cc: PHP Internals <internals@lists.php.net>
References: <200305161525.04359.holger.burbach@gonicus.de> <Pine.LNX.4.53.0305161538480.21410@jdi.jdimedia.nl> <200305221504.25528.holger.burbach@gonicus.de>
In-Reply-To: <200305221504.25528.holger.burbach@gonicus.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <200305221506.52985.holger.burbach@gonicus.de>
Subject: Re: [PHP-DEV] PECL Package Proposal: kadm5 - REPOST
From: holger.burbach@gonicus.de (Holger Burbach)

On Donnerstag, 22. Mai 2003 15:04, Holger Burbach wrote:
> Hi Derick,
>
> can you please have another look at my PECL module kadm5? I think that I
> have fixed all the issues you mentioned.

Sorry, the sources can be found at:

ftp://oss.gonicus.de/pub/php/php-kadm5/php-kadm5-0.2.3/

> Well, hoping to get the final vote "+1" from you. ;-)
> Thanks in advance.
>
> Bye
> Holger
>
> On Friday, 16. Mai 2003 15:46, Derick Rethans wrote:
> > On Fri, 16 May 2003, Sander Roobol wrote:
> > > On Fri, May 16, 2003 at 03:25:04PM +0200, Holger Burbach wrote:
> > > > There is a new release of kadm5 with some minor changes. The sources
> > > > can be found at:
> > > >
> > > > ftp://oss.gonicus.de/pub/php-kadm5/php-kadm5-0.2.2/
> > >
> > > Looks fine, BUT (Derick, still reading? :)
> >
> > 1. The biggest problem I see is that the extension is throwing E_ERRORs
> >    which extensions really should not do if they do not leave *PHP* in
> >    an unstable state (there is also no \n required at the end of the
> > text, and in the best case php_error_docref should be used).
>
> Fixed.
>
> > 2. Check our CODING STANDARDS file again :)
>
> Fixed. At least I hope so ;-)
>
> > 3. I would recommend to use this naming (As example):
> >    kadm5_principal_create
> >    kadm5_principal_modify
> >
> >    instead of:
> >    kadm5_create_principal
> >    kadm5_modify_principal
>
> Well, I see your point, but changing the function names gets quite
> confusing for someone who is familiar with the kadm5 C API. I would prefer
> to keep them the way they are.
>
> > 4. There are no prototypes for the PHP_FUNCTIONs
>
> Fixed.
>
> > 5. There should be atleast one test per function, if possible.
>
> If someone has a clever idea, how to implement these test without accessing
> a real Kerberos server, I would love to do it.
>
> > 6. The package file has some unescapted entities (the & in "Cleanup in
> >    kadm5.c: Removal of confirm_kadm5_compiled & RINIT/RSHUTDOWN" for
> >    example)
>
> Fixed.